Repository navigation
docs: add a release guide with a browser smoke test of the published build - #849
Open
tyler-reitz wants to merge 2 commits into
Open
tyler-reitz wants to merge 2 commits into
tyler-reitz wants to merge 2 commits into
Conversation
…build Adds "Publishing a release" to CONTRIBUTING.md and scripts/release-smoke/run.sh, which installs a published version into a Vite app and a Next.js App Router app, production-builds both, renders a hook in headless Chromium, and fails on any page error, console error or failed request. It fails on 4.2.4 (FirebaseExtended#759) and passes on 4.3.0. Refs FirebaseExtended#848
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #848, taking the suggestion there: a release guide an agent or maintainer can follow, instead of another CI pipeline.
What changed
.github/CONTRIBUTING.mdgets a "Publishing a release (maintainers)" section with five steps: confirmmainis green, bump the version, smoke-test the bump commit's-expbuild in a Vite app and a Next.js App Router app, publish a GitHub release, verify.Verification
The smoke test in step 3 was run as written, against production builds in headless Chromium:
Calling `require` for "react" in an environment that doesn't expose the `require` function/(dynamic usage of require is not supported)main)Caveats
test.yamlandbuild.shimplement today. The 4.3.0 release run published from CI.