Skip to content

feat(config)!: reject obsolete Run configuration forms - #614

Merged
LukeMathWalker merged 6 commits into
mainfrom
amp/remove-legacy-run-config
Sep 3, 2026
Merged

feat(config)!: reject obsolete Run configuration forms#614
LukeMathWalker merged 6 commits into
mainfrom
amp/remove-legacy-run-config

Conversation

@LukeMathWalker

@LukeMathWalker LukeMathWalker commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Why

OpenFirma is alpha and exposes one strict current Run configuration contract. Flat capability source fields and the codex_cli policy alias are obsolete alternate representations; accepting them through runtime or firma config would leave multiple meanings for the same settings.

What changed

  • Retain only tagged capability.source; reject flat capability.kind / capability.path in defaults and every named profile.
  • Retain only keyed executable_policies.codex; reject codex_cli in all profile shapes.
  • Remove compatibility-only schema fields, runtime merge/fallback/path-rebase branches, helpers, fixtures, and generated/public syntax.
  • Prove firma config reaches its existing complete typed-validation boundary and fails before any write for standard, inline, selected, unselected, malformed, and mixed old/current forms.
  • Preserve canonical PR feat(config)!: make Run profile merging deterministic #613 layering, path rebasing, generated defaults, CLI precedence, and runtime behavior.
  • Use current identity terminology when a profile value is incorrectly placed in [sidecar.authority].agent_id.

Breaking contract

Removed forms are rejected rather than migrated, aliased, or ignored. Use tagged capability.source and keyed executable_policies.codex. Failed firma config validation leaves existing scaffold files byte-identical.

Atomic revisions

  1. cb7ec616 — accepted plan and independent plan-review dispositions.
  2. 227b4d52 — reject flat capability sources across schema, runtime, CLI scaffolding, tests, and current docs.
  3. 0fe1d9de — reject codex_cli across the same owned boundaries.
  4. 67b7b1ac — use current Run identity terminology.
  5. e80c6a27 — record the independent implementation review and its mechanical-plan finding.
  6. 7d8e5f83 — immediately remove the plan artifact.

Plan and independent review

  • Accepted plan and unchanged plan-review findings: cb7ec616: remove-legacy-run-config-plan.md.
  • Independent implementation review and disposition: e80c6a27. No code finding survived; the expected plan-presence finding is resolved by the immediate child.
  • Mechanical plan removal: 7d8e5f83. No plan Markdown remains at the tip or in the PR diff.

@LukeMathWalker
LukeMathWalker force-pushed the amp/remove-legacy-run-config branch from fd725dc to 8907a80 Compare August 27, 2026 19:33
@LukeMathWalker
LukeMathWalker force-pushed the amp/remove-legacy-run-config branch from 8907a80 to 4523167 Compare August 27, 2026 19:55
@LukeMathWalker
LukeMathWalker force-pushed the amp/remove-legacy-run-config branch from 4523167 to 9f6205c Compare August 27, 2026 20:35
@LukeMathWalker
LukeMathWalker force-pushed the amp/remove-legacy-run-config branch from 9f6205c to d327cd7 Compare August 28, 2026 05:36
@LukeMathWalker
LukeMathWalker force-pushed the amp/remove-legacy-run-config branch from d327cd7 to b37a58c Compare August 28, 2026 10:21
@LukeMathWalker LukeMathWalker changed the title feat(config)!: remove legacy Run configuration forms feat(config)!: remove legacy configuration surfaces Aug 28, 2026
@LukeMathWalker
LukeMathWalker force-pushed the amp/remove-legacy-run-config branch from b37a58c to 1593932 Compare August 28, 2026 10:55
@LukeMathWalker
LukeMathWalker force-pushed the amp/remove-legacy-run-config branch 3 times, most recently from 0d8f9dd to 549016a Compare August 28, 2026 13:25
@LukeMathWalker LukeMathWalker changed the title feat(config)!: remove legacy configuration surfaces feat(config)!: reject obsolete Run configuration forms Aug 28, 2026
@LukeMathWalker
LukeMathWalker changed the base branch from amp/run-profile-patch-merge to amp/authority-non-zero-runtime-ttls August 28, 2026 13:25
@LukeMathWalker
LukeMathWalker force-pushed the amp/remove-legacy-run-config branch 2 times, most recently from efe4e8d to 1931aec Compare September 1, 2026 16:56
@luca-iachini
luca-iachini added this pull request to the merge queue Sep 2, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Sep 2, 2026
Base automatically changed from amp/authority-non-zero-runtime-ttls to amp/run-profile-patch-merge September 2, 2026 07:56
@luca-iachini
luca-iachini deleted the branch main September 2, 2026 07:56
@luca-iachini luca-iachini reopened this Sep 2, 2026
@LukeMathWalker
LukeMathWalker added this pull request to the merge queue Sep 2, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Sep 2, 2026
@luca-iachini
luca-iachini added this pull request to the merge queue Sep 2, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Sep 2, 2026
@luca-iachini
luca-iachini force-pushed the amp/remove-legacy-run-config branch 4 times, most recently from 31aabd0 to 1931aec Compare September 2, 2026 17:11
@LukeMathWalker
LukeMathWalker added this pull request to the merge queue Sep 3, 2026
@LukeMathWalker
LukeMathWalker removed this pull request from the merge queue due to a manual request Sep 3, 2026
@LukeMathWalker
LukeMathWalker added this pull request to the merge queue Sep 3, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Sep 3, 2026
@LukeMathWalker
LukeMathWalker changed the base branch from amp/run-profile-patch-merge to main September 3, 2026 06:48
@LukeMathWalker
LukeMathWalker force-pushed the amp/remove-legacy-run-config branch from 1931aec to 7d8e5f8 Compare September 3, 2026 06:52
@LukeMathWalker
LukeMathWalker added this pull request to the merge queue Sep 3, 2026
Merged via the queue into main with commit 25906a8 Sep 3, 2026
31 checks passed
@LukeMathWalker
LukeMathWalker deleted the amp/remove-legacy-run-config branch September 3, 2026 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants