Skip to content

feat(CI): Set up CodSpeed - #68

Merged
emyller merged 1 commit into
mainfrom
feat/codspeed
Oct 29, 2026
Merged

feat(CI): Set up CodSpeed#68
emyller merged 1 commit into
mainfrom
feat/codspeed

Conversation

@emyller

@emyller emyller commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Closes SDK-20.

Set up CodSpeed in GitHub Actions.

🤖 Generated with Claude Code

@emyller @claude
feat(CI): Set up CodSpeed
c2ab412 
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@emyller
emyller requested a review from a team as a code owner October 29, 2026 20:18
@emyller
emyller requested review from khvn26 and removed request for a team October 29, 2026 20:18
@linear-code

linear-code Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

SDK-20

@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •
edited
Loading

Copy link
Copy Markdown

Review in Change Stack →

Walkthrough

The pull request adds a CodSpeed benchmark harness, an Erlang NIF for instrumentation hooks, and SDK benchmark operations for three environment sizes. It adds Makefile targets to build and run the benchmarks, submodule references for benchmark assets, and a workflow that runs benchmarks on pushes to main, pull requests, and manual dispatches. The formatter input now includes .exs files under bench.

Priority: Low

Estimated code review effort: 3 (Moderate) | ~25 minutes

Merge Risk: Low · up to c2ab4

This adds CodSpeed benchmarking and does not change SDK runtime behaviour. The benchmark runner can report timings for an unexpected lookup result without failing, which could mislead performance tracking. Add result assertions to the benchmark callbacks and remove the tag from the submodule's branch setting; neither blocks the merge.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codspeed

codspeed Bot commented Oct 29, 2026

Copy link
Copy Markdown

Congrats! CodSpeed is installed 🎉

🆕 12 new benchmarks were detected.

You will start to see performance impacts in the reports once the benchmarks are run from your default branch.

Detected benchmarks
Open in CodSpeed

coderabbitai[bot]
coderabbitai Bot reviewed Oct 29, 2026
View reviewed changes

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: cd65cf67-66c3-4a8c-8c0e-8dbf8fa99ee7
Commits

Reviewing files that changed from the base of the PR and between 77b5e9a and c2ab412.

Files selected for processing: 9
  • .formatter.exs
  • .github/workflows/codspeed.yml
  • .gitmodules
  • Makefile
  • bench/codspeed.exs
  • bench/instrument-hooks
  • bench/instrument_hooks_nif.c
  • bench/sdk_benchmark.exs
  • test/support/sdk-benchmarks

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Comment thread .gitmodules Resolved
Comment thread bench/sdk_benchmark.exs Resolved
@emyller
emyller merged commit edb95fb into main Oct 29, 2026
6 checks passed
@emyller
emyller deleted the feat/codspeed branch October 29, 2026 21:19
@flagsmithdev flagsmithdev mentioned this pull request Oct 21, 2026
Merged
emyller pushed a commit that referenced this pull request Nov 4, 2026
@flagsmithdev
chore(main): release 2.4.0 (#54)
9301401 
🤖 I have created a release *beep* *boop*
---


##
[2.4.0](v2.3.1...v2.4.0)
(2026-11-04)


### Features

* **CI:** Set up CodSpeed
([#68](#68))
([edb95fb](edb95fb))
* **Flag Dependency:** Evaluate flags that depend on other flags in
local evaluation
([#67](#67))
([260c966](260c966))


### Bug Fixes

* Send identity trait values as plain JSON values
([#60](#60))
([f259ff8](f259ff8))


### CI

* Label Renovate's SDK spec bump PRs
([#62](#62))
([77b5e9a](77b5e9a))
* Run the Flagsmith SDK behavioural spec
([#61](#61))
([45b5617](45b5617))
* setup Renovate for engine-test-data tracking
([#56](#56))
([60090c0](60090c0))


### Other

* Remove amannn/action-semantic-pull-request workflow
([#53](#53))
([19414f3](19414f3))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments
@khvn26 khvn26 khvn26 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@emyller @khvn26