Skip to content

fix(Engine): Standardise regex matching in the Elixir server-side SDK - #69

Open
linear-code[bot] wants to merge 1 commit into
mainfrom
linear/sdk-30-standardise-regex-matching-in-the-elixir-server-side-e7ff
Open

linear-code[bot] wants to merge 1 commit into
mainfrom
linear/sdk-30-standardise-regex-matching-in-the-elixir-server-side-e7ff

Conversation

@linear-code

@linear-code linear-code Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

In local evaluation, Matches regex segment conditions matched anywhere in the trait value, so prod matched nonproduction. Other SDKs and the Flagsmith documentation say the match must start at the beginning of the value, without having to cover the whole value.

Changes

  • Regex conditions only match from the start of the trait value, e.g. prod matches production but not nonproduction.
  • The start constraint applies to every alternative, e.g. prod|dev doesn't match nondevelopment.
  • Regex conditions still don't have to match the full value.

Closes https://linear.app/flagsmith/issue/SDK-30/standardise-regex-matching-in-the-elixir-server-side-sdk

Review effort: 1/5

Anchor regex segment conditions at the start of the trait value, for every
alternative, without requiring a full-string match.

Generated with [Linear](https://linear.app/flagsmith/agent-session/58bae237-657f-42a7-a3f0-4a18638a498f)

Co-authored-by: linear-code[bot] <222613912+linear-code[bot]@users.noreply.github.com>
@linear-code
linear-code Bot requested a review from a team as a code owner November 3, 2026 15:57
@linear-code
linear-code Bot requested review from emyller and removed request for a team November 3, 2026 15:57
@linear-code

linear-code Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

SDK-30

@coderabbitai

coderabbitai Bot commented Nov 3, 2026

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: ea7eda0d-6536-4fb6-9d40-7e518d968f0e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.

@linear-code

linear-code Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@codspeed

codspeed Bot commented Nov 3, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 12 untouched benchmarks


Comparing linear/sdk-30-standardise-regex-matching-in-the-elixir-server-side-e7ff (906bfec) with main (edb95fb)

Open in CodSpeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants