@@ -1148,6 +1148,10 @@ public void testGetExperimentFlagRecordsNoExposureWhenNotEnrolledOrDisabled()
11481148 // enrolled, but the flag is off
11491149 assertEquals (Boolean .FALSE ,
11501150 client .getExperimentFlag ("disabled_feature" , "user-1" ).getEnabled ());
1151+ // enrolled, but the flag has no variant
1152+ Flag noVariant = (Flag ) client .getExperimentFlag ("no_variant" , "user-1" );
1153+ assertEquals (Boolean .TRUE , noVariant .getExperiment ().getInExperiment ());
1154+ assertNull (noVariant .getVariant ());
11511155
11521156 verify (processor , never ()).trackExposureEvent (any (), any (), any (), any (), any ());
11531157 }
@@ -1175,39 +1179,85 @@ public void testGetExperimentFlagFallsBackToTheDefaultHandlerWithoutAnExposure(
11751179 verify (processor , never ()).trackExposureEvent (any (), any (), any (), any (), any ());
11761180 }
11771181
1178- @ Test
1179- public void testGetExperimentFlagRecordsNoExposureWithLocalEvaluation ()
1180- throws JsonProcessingException , FlagsmithClientError {
1181- String baseUrl = "http://bad-url" ;
1182+ /**
1183+ * A locally evaluating client serving
1184+ * {@link FlagsmithTestHelper#getEnvironmentDocumentWithExperiment()}.
1185+ */
1186+ private static FlagsmithClient localExperimentClient (EventProcessor processor ) {
11821187 MockInterceptor interceptor = new MockInterceptor ();
1183- EventProcessor processor = mock (EventProcessor .class );
11841188 interceptor .addRule ()
1185- .get (baseUrl + " /environment-document/" )
1189+ .get ("http://bad-url /environment-document/" )
11861190 .anyTimes ()
1187- .respond (
1188- MapperFactory .getMapper ()
1189- .writeValueAsString (FlagsmithTestHelper .environmentModel ()),
1190- MEDIATYPE_JSON );
1191-
1191+ .respond (FlagsmithTestHelper .getEnvironmentDocumentWithExperiment (), MEDIATYPE_JSON );
11921192 FlagsmithClient client = FlagsmithClient .newBuilder ()
11931193 .withConfiguration (FlagsmithConfig .newBuilder ()
1194- .baseUri (baseUrl )
1194+ .baseUri ("http://bad-url" )
11951195 .addHttpInterceptor (interceptor )
11961196 .withEventProcessor (processor )
11971197 .withLocalEvaluation (true )
11981198 .build ())
11991199 .setApiKey ("ser.abcdefg" )
12001200 .build ();
12011201 client .updateEnvironment ();
1202+ return client ;
1203+ }
1204+
1205+ @ Test
1206+ public void testGetExperimentFlagRecordsAnExposureWithLocalEvaluationWhenEnrolled ()
1207+ throws FlagsmithClientError {
1208+ EventProcessor processor = mock (EventProcessor .class );
1209+ FlagsmithClient client = localExperimentClient (processor );
1210+ Map <String , Object > traits = Collections .singletonMap ("plan" , "premium" );
1211+
1212+ Flag flag = (Flag ) client .getExperimentFlag ("checkout" , "user-1" , traits );
12021213
1203- BaseFlag flag = client .getExperimentFlag ("some_feature" , "user-1" );
1214+ assertEquals ("new checkout" , flag .getValue ());
1215+ assertEquals ("treatment" , flag .getVariant ());
1216+ assertEquals (42 , flag .getExperiment ().getId ());
1217+ assertEquals ("Checkout experiment" , flag .getExperiment ().getName ());
1218+ assertEquals (Boolean .TRUE , flag .getExperiment ().getInExperiment ());
1219+ verify (processor ).trackExposureEvent ("checkout" , "user-1" , "treatment" , traits ,
1220+ Collections .singletonMap ("experiment_id" , 42 ));
1221+ }
12041222
1205- assertTrue (flag instanceof Flag );
1206- assertNull (((Flag ) flag ).getVariant ());
1207- assertNull (((Flag ) flag ).getExperiment ());
1223+ private static Stream <Arguments > localExperimentFlagsWithoutAnExposure () {
1224+ return Stream .of (
1225+ // outside the rollout
1226+ Arguments .of ("checkout" , "user-1" , "free" , "control" , Boolean .FALSE ),
1227+ // an identity override carries no experiment
1228+ Arguments .of ("checkout" , "user_overridden" , "premium" , "overridden checkout" , null ),
1229+ // no experiment on the feature
1230+ Arguments .of ("plain" , "user-1" , "premium" , "hello" , null ));
1231+ }
1232+
1233+ @ ParameterizedTest
1234+ @ MethodSource ("localExperimentFlagsWithoutAnExposure" )
1235+ public void testGetExperimentFlagRecordsNoExposureWithLocalEvaluation (
1236+ String featureName , String identifier , String plan , String expectedValue ,
1237+ Boolean expectedInExperiment ) throws FlagsmithClientError {
1238+ EventProcessor processor = mock (EventProcessor .class );
1239+ FlagsmithClient client = localExperimentClient (processor );
1240+
1241+ Flag flag = (Flag ) client .getExperimentFlag (
1242+ featureName , identifier , Collections .singletonMap ("plan" , plan ));
1243+
1244+ assertEquals (expectedValue , flag .getValue ());
1245+ assertEquals (expectedInExperiment ,
1246+ flag .getExperiment () == null ? null : flag .getExperiment ().getInExperiment ());
12081247 verify (processor , never ()).trackExposureEvent (any (), any (), any (), any (), any ());
12091248 }
12101249
1250+ @ Test
1251+ public void testEnvironmentFlagsCarryNoExperimentWithLocalEvaluation ()
1252+ throws FlagsmithClientError {
1253+ FlagsmithClient client = localExperimentClient (mock (EventProcessor .class ));
1254+
1255+ Flag flag = (Flag ) client .getEnvironmentFlags ().getFlag ("checkout" );
1256+
1257+ assertEquals ("control" , flag .getValue ());
1258+ assertNull (flag .getExperiment ());
1259+ }
1260+
12111261 /**
12121262 * An events-enabled config serving the experiment identity flags, which records each events
12131263 * batch as "environment key|body".
0 commit comments