Skip to content

Commit 0a33964

Browse files
committed
docs: the numeric-coercion deviation is declared, not withheld
Leftover from the declare-and-fail change: the summary still opened with 'Withheld because of a defect' for a capability the same commit had declared. Signed-off-by: Simon Schrottner <simon.schrottner@flagsmith.com>
1 parent 4f46af7 commit 0a33964

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

‎tests/test_provider_conformance.py‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -98,10 +98,9 @@ def new_provider() -> FlagsmithProvider:
9898
# initialize/shutdown lifecycle the suite can assert against. Declaring them would make
9999
# those scenarios pass without the provider having done anything, and a vacuous pass is
100100
# worse than a skip.
101-
# DISABLED_FLAGS and NUMERIC_COERCION are declared and both fail. This provider attempts
101+
# DISABLED_FLAGS and NUMERIC_COERCION are declared and both fail: this provider attempts
102102
# each and gets it wrong -- it raises GENERAL for a disabled flag, and type-checks a float
103-
# that Flagsmith stores as a string -- so the scenarios run and the failures stay in the
104-
# results rather than being withheld into skips.
103+
# that Flagsmith stores as a string.
105104
capabilities={
106105
Capability.OBJECT,
107106
Capability.LARGE_INTEGERS,
@@ -130,7 +129,8 @@ def new_provider() -> FlagsmithProvider:
130129
capability=Capability.NUMERIC_COERCION,
131130
issue="",
132131
summary=(
133-
"Withheld because of a defect rather than a design choice. Flagsmith has no "
132+
"Declared and failing rather than withheld, because the provider does have a float "
133+
"accessor and gets the answer wrong. Flagsmith has no "
134134
"float type -- feature_state_value is natively boolean, integer or string -- "
135135
"so every float is stored as a string, and _BASIC_FLAG_TYPE_MAPPINGS[FLOAT] "
136136
"is a plain isinstance check against `float`. A Flagsmith float therefore "

0 commit comments

Comments
 (0)