Commit cf3d0b2
fix: JsonMapper / data.source.parse don't touch LEAN-inherited properties (v0.1.1)
v0.1.0 had a parse-time bug surfaced the moment a consumer actually
ran the bridge against the live API: FlashAlphaJsonMapper.PopulateProperties
(C#) iterates ALL public properties on the bar — including the inherited
BaseData.Symbol whose declared type is QuantConnect.Symbol, not string.
The JSON key "symbol":"SPY" snake-cased to "Symbol" and the deserializer
threw JsonException trying to convert "SPY" into a QC Symbol object. The
Python parse() loop hit the same hazard via setattr(bar, "Symbol", "SPY")
silently clobbering the QC Symbol instance with the raw ticker string.
Fix: only walk properties declared on the bar SUBCLASS (and any non-
QuantConnect ancestors). LEAN-owned surface (Symbol/Time/EndTime/Value/Price)
is set explicitly by FlashAlphaSource.Parse before this method runs.
CI tests passed previously only because they skipped when FLASHALPHA_API_KEY
was absent — no live data reached the parse path. Setting the secret on
the next CI run will exercise it for real.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>1 parent a4051c4 commit cf3d0b2
6 files changed
Lines changed: 46 additions & 6 deletions
File tree
- src
- csharp/FlashAlpha.QuantConnect
- Data
- python
- src/flashalpha_quantconnect
- data
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
11 | 17 | | |
12 | 18 | | |
13 | 19 | | |
| |||
26 | 32 | | |
27 | 33 | | |
28 | 34 | | |
29 | | - | |
| 35 | + | |
| 36 | + | |
30 | 37 | | |
Lines changed: 20 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
31 | 38 | | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
32 | 48 | | |
33 | | - | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
34 | 53 | | |
35 | 54 | | |
36 | 55 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
84 | 84 | | |
85 | 85 | | |
86 | 86 | | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
87 | 101 | | |
88 | 102 | | |
89 | | - | |
| 103 | + | |
90 | 104 | | |
91 | 105 | | |
92 | 106 | | |
| |||
0 commit comments