Skip to content

Encode NSImage.jpegData as JPEG instead of JPEG 2000 #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jeehut merged 1 commit into from
Oct 15, 2026
Merged

Encode NSImage.jpegData as JPEG instead of JPEG 2000 #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/HandySwiftUI/Extensions/ImageExt.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ extension Image {
else { return nil }

return bitmapImage.representation(
using: .jpeg2000,
using: .jpeg,
properties: [NSBitmapImageRep.PropertyKey.compressionFactor: NSNumber(value: compressionQuality)]
)
}
Expand Down
22 changes: 22 additions & 0 deletions Tests/HandySwiftUITests/ImageExtTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
#if os(macOS)
import AppKit
import Testing

@testable import HandySwiftUI

struct ImageExtTests {
@Test
func jpegDataEncodesAsJPEG() throws {
let image = NSImage(size: NSSize(width: 8, height: 8), flipped: false) { rect in
NSColor.systemRed.setFill()
rect.fill()
return true
}

let data = try #require(image.jpegData(compressionQuality: 0.8))

// Every JPEG file starts with the SOI marker followed by the next marker's 0xFF (JPEG 2000 starts with 0x00 0x00 0x00 0x0C)
#expect(Array(data.prefix(3)) == [0xFF, 0xD8, 0xFF])
}
}
#endif
Loading