Repository navigation
Raise the minimum OS versions to iOS 18 and macOS 15 - #23
Merged
Merged
Conversation
HandySwiftUI 3.0.0 targets iOS 18, macOS 15, tvOS 18, visionOS 2 and watchOS 10. With these minimums, every availability check for iOS 17, macOS 14, tvOS 17 and watchOS 10 is always true, so the annotations and the fallback branches go away. The internal onValueChange bridge only existed to call the right onChange variant below iOS 17 and is replaced by onChange directly.
All five minimums now come from the same release year, so no API from an older SDK generation gets combined with newer ones.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First step towards 3.0.0: raise the minimum OS versions and drop the checks that are now always true.
@availableand#availablecheck for iOS 17, macOS 14, tvOS 17 and watchOS 10 is gone, along with its fallback branch.onValueChangehelper is gone. It only existed to pick the rightonChangevariant below iOS 17. Callers now useonChangedirectly.BindingExtdoc example uses the two-parameteronChange.All five minimums come from the same release year. No API in the package needs watchOS 11, but mixing API generations across platforms is asking for trouble.
Evidence
main.After:
swift buildandswift testpass on macOS, 37 tests. No new warnings. A search for@available,#availableand#unavailablefinds only thedeprecated: 26.0notes onWebView. CI builds the other platforms.Merge Danger
Door: two-way
Blast Radius: consumers
Apps below iOS 18, macOS 15, tvOS 18, visionOS 2 or watchOS 11 can't update to 3.0.0. That's why this goes into a major release. Nothing in the public API changes.