fix: reload dashboard under http node root - #2152
Conversation
|
Is the change to use the setup url in the case of authentication error anything to do with issue #2149 or is that to address a different issue? |
9c2bc83 to
0dcf66c
Compare
|
Good point. I narrowed that part out so the auth path no longer depends on the |
|
While you have your brain in gear for the dashboard url, you might like to have a look at #2132. Does the Open Dashboard button in the editor work if the root is altered? |
|
I checked both paths. The Open Dashboard button already prefixes the configured dashboard path with RED.settings.httpNodeRoot, so it produces the correct URL when the root is changed. The #2132 failure is separate: the layout editor save request derived its API path from the dashboard URL and then prepended the editor path, which could duplicate the custom root. I fixed that path and added coverage for default, shared, and different admin/node roots in #2165. I kept this PR scoped to the forced-reload behavior from #2149. |
n-lark
left a comment
There was a problem hiding this comment.
Approved - thank you for the contribution @Saithej2k!
Tested under a custom httpNodeRoot (/nr): a forced reload now targets /nr/dashboard instead of /dashboard → 404, and the default root still reloads to /dashboard. The auth-before-_setup case is covered by the current-URL fallback, so narrowing out the _setup-URL handling doesn't regress it. Open Dashboard button / #2132 is separate (tracked in #2165), out of scope here.
Summary
Testing
Closes #2149