handbook: point Edit this page at Studio - #5690
Open
dimitrieh wants to merge 2 commits into
Open
Conversation
The handbook tells everyone that Edit this page opens Nuxt Studio and needs no git knowledge, but the link opened GitHub's file editor. Point it at the Studio route instead, carrying the current path in ?redirect= the way Studio's own shortcut does, so a signed-in visitor gets the editor on the page they are reading and everyone else signs in and comes back to it. GitHub stays available as a second link. The route comes from the module's runtime config rather than a repeated literal. Docs pages keep their GitHub link: that markdown lives in FlowFuse/flowfuse, which Studio is not configured for. The Node-RED and hardware guides keep theirs too, since they are still 11ty pages and carry no Nuxt app for Studio to mount on. Also corrects two handbook references to src/handbook/, which moved to nuxt/content/handbook/ during the migration.
Contributor
Author
|
@ZJvandeWeg came across this while looking into how we can schedule multiple things hitting the website together for a release. The "edit this page" is essentially not even needed anymore as nuxt pages get this in the bottom left corner: |
✅ Deploy Preview for flowforge-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
hyperlink, the link checker in the shared build workflow, reads /_studio as a broken link because that route has no prerendered file, and the tool takes no ignore list. pages/docs/[...slug].vue already keeps its edit link out of the static HTML this way.
Member
|
This depends on: https://github.com/FlowFuse/website/pull/5694/changes Reason is, that Nuxt Studio doesn't support feature branches. And if you now edit with Nuxt studio, you'll publish to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Handbook pages carry an "Edit this page" link, and the handbook tells everyone it opens our CMS and needs no git knowledge. It actually opened GitHub's file editor. This points it at Studio on the page you are reading, and keeps GitHub as a second link for anyone who prefers it.
If you are already signed in, the editor appears on the page. If not, you sign in with GitHub and come back to that same page.
Docs pages and the Node-RED guides keep their GitHub links on purpose. Docs text lives in the
FlowFuse/flowfuserepository, and the guides are not Nuxt pages, so Studio cannot open on either.Two handbook sentences also still pointed at the old
src/handbook/folder, which moved tonuxt/content/handbook/. Corrected.Related Issue(s)
None.
Checklist