css: stop prose stretching the agent picker brand marks - #5714
Open
dimitrieh wants to merge 1 commit into
Open
Conversation
.prose:not(.prose-natural-size-images) img is (0,2,1) and .ff-agent-tab img was (0,1,1), so on any surface using a plain .prose the prose rule won and every mark rendered at width:100% of the column. The ChatGPT square came out 780px on the changelog entry. The docs page was unaffected because its container carries prose-natural-size-images, and /ai because it renders outside prose. Scoping the rule through the card and the tab strip takes it to (0,3,1), so it holds in prose and out of it.
5 tasks
✅ Deploy Preview for flowforge-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The agent picker's brand marks rendered at full column width on any surface that wraps it in a plain
.prose. On the changelog entry the ChatGPT square came out 780px..prose:not(.prose-natural-size-images) imgis(0,2,1)and forceswidth:100%..ff-agent-tab imgwas only(0,1,1), so it lost regardless of source order. The component's styles are deliberately unlayered to beat Tailwind's@layer utilities, but unlayered does not beat a more specific unlayered rule, which is the case that was missed.Scoping the rule through the card and the tab strip takes it to
(0,3,1).Affected:
prose-natural-size-images/ai: was already fine, renders outside.proseVerified all four surfaces at 375, 414, 768, 1024, 1280 and 1536px. Every mark measures 16x16 in all 24 combinations, and the tab strip still wraps correctly at 375px.
Related Issue(s)
Found while reviewing #5671, which adds a fourth surface for this component.
Checklist