Fix validation

Author: BrandonWeng

.github/workflows/framework-app-store-validation.yml

@@ -97,6 +97,19 @@ jobs:
                       fi
                   done
 
+                  local info_current="$framework_dir/Versions/Current/Resources/Info.plist"
+                  local info_symlink="$framework_dir/Resources/Info.plist"
+                  if [ ! -f "$info_current" ]; then
+                      echo "  ❌ Info.plist missing at Versions/Current/Resources/Info.plist"
+                      errors=$((errors + 1))
+                  else
+                      echo "  ✓ Info.plist located at Versions/Current/Resources/Info.plist"
+                  fi
+                  if [ ! -f "$info_symlink" ]; then
+                      echo "  ❌ Resources/Info.plist symlink missing"
+                      errors=$((errors + 1))
+                  fi
+
                   if [ $errors -gt 0 ]; then
                       return 1
                   fi
@@ -133,21 +146,21 @@ jobs:
 
           FRAMEWORK_PATH="Sources/FluidAudio/Frameworks/ESpeakNG.xcframework"
 
-          # For versioned frameworks (macOS), check that resources are properly accessible
-          for framework_dir in "$FRAMEWORK_PATH"/**/ESpeakNG.framework; do
-              if [ -d "$framework_dir/Resources" ]; then
-                  # Check if Resources is a symlink
-                  if [ -L "$framework_dir/Resources" ]; then
-                      echo "✓ Resources is properly symlinked"
-
-                      # Verify the symlink resolves
-                      if [ -d "$framework_dir/Resources" ]; then
-                          resource_count=$(find "$framework_dir/Resources" -type f | wc -l)
-                          echo "  Found $resource_count resource files"
-                      fi
-                  fi
+          found_resources=false
+          while IFS= read -r -d '' framework_dir; do
+              found_resources=true
+              if [ -L "$framework_dir/Resources" ]; then
+                  echo "✓ $(basename "$framework_dir") Resources symlink resolves"
+                  resource_count=$(find "$framework_dir/Resources" -type f | wc -l | tr -d '[:space:]')
+                  echo "  Found $resource_count resource files"
+              elif [ -d "$framework_dir/Resources" ]; then
+                  echo "⚠️  $(basename "$framework_dir") has a real Resources directory (expected symlink for versioned frameworks)"
               fi
-          done
+          done < <(find "$FRAMEWORK_PATH" -type d -name "ESpeakNG.framework" -print0)
+
+          if [ "$found_resources" = false ]; then
+              echo "⚠️  No ESpeakNG.framework directories found when validating resources"
+          fi
 
           echo "✅ Resources validation complete"
 

.github/workflows/framework-validation.yml

@@ -180,32 +180,37 @@ jobs:
           echo "🔎 Checking for common framework structure issues..."
           echo ""
 
-          # Check for case sensitivity issues in binary names
-          for framework in "$FRAMEWORK_PATH"/**/ESpeakNG.framework/Versions/A; do
-              if [ -d "$framework" ]; then
-                  # Use ls with grep to check for exact case typo on case-insensitive filesystems
-                  if ! ls "$framework" 2>/dev/null | grep -x "ESpeakNG" > /dev/null; then
-                      echo "❌ ERROR: Binary 'ESpeakNG' not found with correct casing"
-                      echo "   This would cause dyld errors at runtime"
-                      exit 1
-                  fi
+          echo "🔠 Verifying binary casing inside versioned frameworks..."
+          found_versioned=false
+          while IFS= read -r -d '' version_dir; do
+              found_versioned=true
+              actual_name=$(python3 -c 'import os, sys; path=sys.argv[1]; target="espeakng"; print(next((n for n in os.listdir(path) if n.lower()==target), ""))' "$version_dir")
+              if [ -z "$actual_name" ]; then
+                  echo "❌ ERROR: No ESpeakNG binary found inside $version_dir"
+                  exit 1
               fi
-          done
+              if [ "$actual_name" != "ESpeakNG" ]; then
+                  echo "❌ ERROR: Binary '$actual_name' found in $version_dir (expected ESpeakNG)"
+                  echo "   This would cause dyld errors on case-sensitive filesystems"
+                  exit 1
+              fi
+          done < <(find "$FRAMEWORK_PATH" -type d -path "*/ESpeakNG.framework/Versions/A" -print0)
 
-          echo "✅ No case sensitivity issues found"
-          echo ""
+          if [ "$found_versioned" = false ]; then
+              echo "  ⚠️  No versioned frameworks found to inspect"
+          else
+              echo "  ✓ Binary casing validated in versioned slices"
+          fi
 
-          # Check for broken symlinks
+          echo ""
           echo "🔗 Checking for broken symlinks..."
-          for framework in "$FRAMEWORK_PATH"/**/ESpeakNG.framework; do
-              if [ -d "$framework" ]; then
-                  while IFS= read -r -d '' link; do
-                      if [ -L "$link" ] && ! [ -e "$link" ]; then
-                          echo "❌ ERROR: Broken symlink: $(basename $link)"
-                          exit 1
-                      fi
-                  done < <(find "$framework" -type l -print0)
-              fi
-          done
+          while IFS= read -r -d '' framework; do
+              while IFS= read -r -d '' link; do
+                  if [ -L "$link" ] && ! [ -e "$link" ]; then
+                      echo "❌ ERROR: Broken symlink: $(basename "$link")"
+                      exit 1
+                  fi
+              done < <(find "$framework" -type l -print0)
+          done < <(find "$FRAMEWORK_PATH" -type d -name "ESpeakNG.framework" -print0)
 
           echo "✅ All symlinks are valid"