feat: add quick fill clipboard foundation - #112
blackman-eric wants to merge 1 commit into
Conversation
c00a4c4 to
6627cfe
Compare
6627cfe to
274d177
Compare
| 'minecraft:lit_blast_furnace': 'blast_furnace:3', | ||
| 'minecraft:brewing_stand': 'brewing:5', | ||
| 'minecraft:chiseled_bookshelf': 'bookshelf:6', | ||
| 'minecraft:crafter': 'crafter:9' |
There was a problem hiding this comment.
The crafter inventory is inaccessible to the Script API -- Mojang just never added support for it.
|
Hi Eric, thanks for contributing! Here are a couple of things to note as you continue developing this PR: The @forestoflight/minecraft-vitest-mocks package can simplify your testing logic (removing the need for functions like To match code style with the rest of the repo, please keep all function parameters on the same line. When getting block, entity, or item components, please use EntityComponentTypes & its equivalents to eliminate the need for a magic string. Since the classes/ folder is getting kinda full and there are several QuickFill classes, go ahead and throw those classes into their own subfolder. There's generally a very good split of concerns between the classes and methods. Some of the methods are a little long for my taste and could be broken down further. If you don't want to worry about that, I'm happy to handle it myself. |
| static AdaptiveShape = 'adaptive'; | ||
|
|
||
| static SpecialShapes = Object.freeze({ | ||
| 'minecraft:furnace': 'furnace:3', |
There was a problem hiding this comment.
Are the furnace, smoker, and blast furnace incompatible because the sets of items they can smelt differ? If so, you should only need them to be separate from one another here if the game doesn't already enforce that constraint through container.setItem().
Summary
Adds clipboard behavior to QuickFill while preserving the existing transfer/reverse behavior when no clipboard is active.
Preset commands (
save,set,delete), persistence, and wildcard editing will be addressed in follow-up PRs.Testing
npm run lintgit diff --check