perf: use deque for BFS queue in get_function_dependency() - #1952
Closed
giulio-leone wants to merge 1 commit into
Closed
perf: use deque for BFS queue in get_function_dependency()#1952giulio-leone wants to merge 1 commit into
giulio-leone wants to merge 1 commit into
Conversation
giulio-leone
had a problem deploying
to
unittest
February 28, 2026 05:03 — with 
GitHub Actions
Failure
GitHub Actions
Failure
giulio-leone
had a problem deploying
to
unittest
February 28, 2026 14:38 — with
GitHub Actions
Failure
GitHub Actions
Failure
get_function_dependency() traverses the call graph via BFS using list.pop(0), which is O(n) per removal. Switch to collections.deque with popleft() for O(1).
giulio-leone
had a problem deploying
to
unittest
February 28, 2026 14:39 — with
GitHub Actions
Failure
GitHub Actions
Failure
Author
|
Hi! Gentle ping — this PR is rebased, CI passes, and ready for review. Happy to address any feedback. Thanks! |
Author
|
Closing — minor perf optimization, low impact. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
get_function_dependency()traverses the call graph via BFS usinglist.pop(0), which is O(n) per removal. For large call graphs this makes traversal O(n²).Solution
Switch to
collections.dequewith.popleft()for O(1) front removal.Changes
metagpt/utils/sanitize.py: Importdeque, init queue asdeque([entrypoint]), use.popleft()Testing
ast.parse()