fix(terminal): yield single-line buffers so end marker is observed - #2111
Closed
Solaris-star wants to merge 1 commit into
Closed
fix(terminal): yield single-line buffers so end marker is observed#2111Solaris-star wants to merge 1 commit into
Solaris-star wants to merge 1 commit into
Conversation
`*lines, tmp = output.splitlines(True)` hid a lone newline-terminated line in `tmp`, so the end-of-command marker was never checked and `run_command` hung forever on Linux/WSL2. Fixes #2110
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Terminal.run_command()hung forever on Linux/WSL2 because_read_and_process_outputused:When the buffer is a single newline-terminated line (the common case for the end-of-command marker), that unpack moves the only line into
tmpand leaveslinesempty — so the marker check never runs and the loop waits for a next byte that never arrives.Every
Engineer2._think()starts withawait self.terminal.run_command("pwd"), so this deadlocks the agent before any LLM call.Change
Treat a buffer that already ends with
\n/\ras a complete line to yield. Keep incomplete fragments intmponly when they lack a trailing newline.Test plan
await Terminal().run_command("pwd")returns promptly on Linux/WSL2Fixes #2110