add "use_scan" option, and enable it only for the main CI builds.

the "clang scan" runs take a HUGE length of time.  We don't need
them to be run on every build of every commit.  Running them only
for one CI build is fine

Author: alandekok

.github/actions/build-freeradius/action.yml

@@ -4,6 +4,9 @@ inputs:
   use_sanitizers:
     description: Enable sanitizers if true
     default: false
+  use_scan:
+    description: Run "clang scan" if true
+    default: false
   cc:
     description: Which CC to use
     default: gcc
@@ -162,15 +165,15 @@ runs:
         [ -d /opt/openssl ] && export PATH=/opt/openssl/bin:$PATH
         make -j `nproc`
 
-    # Disabled on MacOS and when fuzzing to reduce the runtime
+    # only do this on the main CI build, it doesn't help on everything else.
     - name: Clang Static Analyzer
-      if: ${{ inputs.cc == 'clang' && runner.os != 'macOS' && inputs.test_type != 'fuzzing' }}
+      if: ${{ inputs.cc == 'clang' && inputs.use_scan = 'true' }}
       shell: bash
       run: |
         make -j `nproc` scan && [ "$(find build/plist/ -name *.html)" = '' ];
 
     - name: "Clang Static Analyzer: Store assets on failure"
-      if: ${{ inputs.cc == 'clang' && failure() }}
+      if: ${{ inputs.cc == 'clang' && inputs.use_scan = 'true' && failure() }}
       uses: actions/upload-artifact@v6
       with:
         name: clang-scan.tgz

.github/workflows/ci-macos.yml

@@ -192,14 +192,6 @@ jobs:
       run: |
         make -j `nproc`
 
-    - name: "Clang Static Analyzer: Store assets on failure"
-      uses: actions/upload-artifact@v6
-      with:
-        name: clang-scan.tgz
-        path: build/plist/**/*.html
-        retention-days: 30
-      if: ${{ matrix.env.CC == 'clang' && failure() }}
-
     # No detect_leaks support for ASAN on macOS
     - name: Run basic tests (macOS)
       run: |

.github/workflows/ci.yml

@@ -182,6 +182,7 @@ jobs:
         uses: ./.github/actions/build-freeradius
         with:
           use_sanitizers: false
+          use_scan: true
           cc: ${{ matrix.env.CC }}
           test_type: ${{ matrix.env.TEST_TYPE }}
           platform: ${{ matrix.os.imageos }}