multi-server: one profiling run index per make invocation - #5919
Open
marc-casavant wants to merge 1 commit into
Open
multi-server: one profiling run index per make invocation#5919marc-casavant wants to merge 1 commit into
marc-casavant wants to merge 1 commit into
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
Claude Code Review is paused for this repository. To reconnect it, an admin of this repository's GitHub organization (or the account owner, for personal repositories) who can also manage your Claude organization's Code Review settings needs to re-link GitHub in Code Review settings. This is a one-time step.
Tip: disable this comment in your organization's Code Review settings.
arr2036
reviewed
Aug 21, 2026
| @@ -12,7 +12,7 @@ | |||
| # PROFILING_RESULT_PATH. | |||
| # - PROFILING_RESULT_MODE=<ci|dev> Profiling output layout (only meaningful when | |||
| # MODE=profiling). Default `ci`. | |||
| # ci: PROFILING_RESULT_ROOT/<suite>/<test>/<branch>/<commit>/<run-index> | |||
| # ci: PROFILING_RESULT_ROOT/<branch>/<commit>/<run-index>/<suite>/<test> | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change ensures all profiling test results are generated and saved in a directory structure that uses a single run index per make invocation.
Without this change, when tests run in parallel (-j), results from one invocation could scatter across several indexes. This is because the previous implementation computed the index inside each test's recipe.
The index is now calculated once at makefile parse time and before any tests are run, calculated from the workflow run number in CI, highest existing plus one locally.
There's also a minor edit in the README to fix the directory structure of the profiling results.