Validate timer command ID lower bound in xTimerGenericCommandFromTask - #1477
Merged
kstribrnAmzn merged 2 commits intoAug 21, 2026
Merged
Conversation
The task command path validated the command ID only against the upper bound. Add the corresponding lower-bound check so the accepted range is fully constrained.
kstribrnAmzn
approved these changes
Aug 20, 2026
aadityasg
approved these changes
Aug 21, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The task command path in
xTimerGenericCommandFromTask()validatedxCommandIDonly against the upper boundtmrFIRST_FROM_ISR_COMMAND; there was no corresponding lower bound. This change adds the lower bound so the accepted range is fully constrained to the valid task command set.tmrCOMMAND_START_DONT_TRACE(0) is the lowest legitimate task-issued command andtmrCOMMAND_DELETE(5) is the highest; the existing upper bound already excluded the ISR commands. Behaviour for valid commands is unchanged — a rejected command returnspdFAIL, matching the pre-existing rejection path.Scope is the task path only.
xTimerGenericCommandFromISR()is untouched.Test Steps
Tested by creating a demo and checking the output
Checklist:
The unit-test (CMock) suite for the kernel lives in the separate
FreeRTOS/FreeRTOSrepository, not in this repository, so no test was addedhere.
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.