Rebase on master to include deadlock fix - #317
Merged
Merged
Conversation
…cellation When AbortBackgroundRecalc() is called before DoBackgroundRecalcDisplayList creates recalcDone, the abort cannot signal it. If workers subsequently see the cancellation at the early-exit checks and return without removing themselves from runningThreads, recalcDone.Count never reaches zero and recalcDone.Set() is never called, causing WaitOne() to block forever and t.Join() to hang indefinitely. Move the lock(runningThreads) cleanup block outside the cancellation guard so every queued worker unconditionally removes itself from runningThreads and signals recalcDone when it is the last one — regardless of whether it performed any actual work. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014bFdnkBE83221SmUkyXHze
…k-fix-to5ymn Fix deadlock: ensure workers always remove from runningThreads on cancellation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.