Add XML channel mode, and general text sanitization - #1557
Open
nwah wants to merge 3 commits into
Open
Conversation
tschak909
approved these changes
Aug 19, 2026
Contributor
|
This couldn't wait until after the network is 1108? 🤪 |
Collaborator
|
nothing ever happens when we want it to. |
Contributor
Author
You just gotta take a long time to merge it 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out that Gumbo is too HTML-focused to really be general purpose SGML parsing / querying. This adds a separate XML channel mode that uses the tinyxml2 library already in the firmware.
It also adds some helpers for converting HTML entities (
&) and/or UTF-8 characters (”, —) into plain ASCII. This can be used when querying JSON, HTML or XML values.Still a bit of duplication with the different network implementations for the different buses.