✨ Matml Importer - #10
Conversation
8da0603 to
01243c9
Compare
| "qualifier": ["Dependent"] * len(prop_data), | ||
| } | ||
| # TODO @je-cook: Add independent parameter_value | ||
| # 1 |
There was a problem hiding this comment.
Need to change once issue opened
|
|
||
| if (comp := char.chemical_composition) is not None: # noqa: F841 | ||
| # TODO @je-cook: Process Elements more thoroughly | ||
| # 1 |
There was a problem hiding this comment.
need to change once issue opened
b2ab35c to
fd996b0
Compare
CoronelBuendia
left a comment
CoronelBuendia
left a comment
There was a problem hiding this comment.
Whistlestop doc/API review.
| We aim to offer a variety of converters to different formats where direct interfacing cannot easily be achieved. | ||
|
|
||
| We currently offer coverters to a few select neutronics packages but this area will be expanded as the `matproplib` matures. | ||
| We currently offer coverters to a few different formats, this will be expanded as the `matproplib` matures. |
There was a problem hiding this comment.
| We currently offer coverters to a few different formats, this will be expanded as the `matproplib` matures. | |
| We currently offer converters to a few different formats, this will be expanded as `matproplib` matures. |
|
|
||
| ##### Import | ||
|
|
||
| To import a material from a MatML 3.1 xml file. If the importer is unable to process a specific property you specifiy it in `skip_properties` |
There was a problem hiding this comment.
| To import a material from a MatML 3.1 xml file. If the importer is unable to process a specific property you specifiy it in `skip_properties` | |
| To import a material from a MatML 3.1 xml file. If the importer is unable to process a specific property, you can specify it in `skip_properties` |
There was a problem hiding this comment.
First sentence is not really a sentence!
| ##### Import | ||
|
|
||
| To import a material from a MatML 3.1 xml file. If the importer is unable to process a specific property you specifiy it in `skip_properties` | ||
| to ignore it. Please bare with us while we enable importing for different property types. |
There was a problem hiding this comment.
| to ignore it. Please bare with us while we enable importing for different property types. | |
| to ignore it. Please bear with us while we enable importing for different property types. |
| "tensile_ultimate_strength": "average_ultimate_tensile_stress", | ||
| "tensile_yield_strength": "average_yield_stress", |
There was a problem hiding this comment.
Hmm tricky... it's probably fine, but this should technically be something the user decides somehow (e.g. minimum). I would not change anything, just leaving this for posteriority
| """Function to convert material to secondary format""" | ||
|
|
||
| @classmethod | ||
| def import_from(cls, obj, /) -> Material: |
There was a problem hiding this comment.
Would it be possible to have an export_to on materials (or within their converters somehow).
I'm thinking that something along the lines of:
my_steel.export_to_xml("my_file.xml")
or a similar one-liner would be nice (not that I would use it...)
I know that at present it is only my_steel.convert(...).export(); just thinking what a typical tripping up point would be for a new user who maybe doesn't assiduously readthedocs.
2 participants
Allows importing from MatML xml format, I have included the spec as it was a bit difficult to find online.
TODO