fix(ui): unify icon assets and usage across the design system and Web UI - #2708
Merged
Conversation
Update reviewed icon assets and aliases, add NumberBadge, and migrate component previews and product icon usages. Watch shared UI sources in both dev servers to invalidate stale inline SVG modules, with asset and hot-update regression coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: N/A — no linked issue.
Type and Areas
Type: Bug fix / UI/UX / refactor
Areas: Web UI, design system, component library, Design Lab, Vite development tooling, tests, docs.
Motivation / Impact
The shared catalog and its consumers used inconsistent icon geometry, and development servers could retain outdated SVG modules after asset changes.
This update aligns component previews and product interfaces with the shared assets, reduces duplicate implementations, and makes icon updates visible during development.
Verification
The following results were recorded before the latest rebase. The rebased commit has an identical patch, verified with
git range-diff; checks have not been rerun on the current HEAD.Passed:
pnpm run design-system:checkpnpm --dir design-system/apps/design-lab run testpnpm --dir src/web-ui exec tsc --noEmitpnpm run theme:visual-contractpnpm --dir src/web-ui exec vitest run --maxWorkers=2 src/flow_chat/components/HarnessProfileSelector.test.tsx src/infrastructure/design-system/IconUsageIntegration.test.tsx src/app/components/NavPanel/navigationIconIntegration.test.tsgit -c core.safecrlf=false diff --checkKnown verification limitations:
pnpm run check:webandpnpm run theme:color-audit:allencountered stale MiniApp and native-mobile generated artifacts. Unrelated generated files and governance baselines were not modified.pnpm --dir src/web-ui exec vitest run --maxWorkers=1 src/app/scenes/agents/AgentsScene.test.tsxreported four failures. The same failures were reproduced using the pre-change code.Reviewer Notes
Checklist