Skip to content

fix(ui): unify icon assets and usage across the design system and Web UI - #2708

Merged
kev1n77 merged 1 commit into
GCWing:1.0.0-explorefrom
kev1n77:fmy/ui-sys
Aug 31, 2026
Merged

fix(ui): unify icon assets and usage across the design system and Web UI#2708
kev1n77 merged 1 commit into
GCWing:1.0.0-explorefrom
kev1n77:fmy/ui-sys

Conversation

@kev1n77

@kev1n77 kev1n77 commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Correct and extend the shared icon catalog, including thinking, git, duplicate, terminal, and Harness profile icons.
  • Migrate remaining common icons in Web UI and Design Lab to the shared catalog, preserving sizing, interaction states, and animation classes.
  • Update the mode selector to use minimal, standard, ultimate, and creative icons without changing persisted profile IDs or selection behavior.
  • Add NumberBadge and reuse its anatomy in ToolbarBadge.
  • Fix development asset watching so updated SVG assets refresh in both Design Lab and Web UI.
  • Add regression coverage and remove unused custom sidebar icons.

Fixes: N/A — no linked issue.

Type and Areas

Type: Bug fix / UI/UX / refactor

Areas: Web UI, design system, component library, Design Lab, Vite development tooling, tests, docs.

Motivation / Impact

The shared catalog and its consumers used inconsistent icon geometry, and development servers could retain outdated SVG modules after asset changes.

This update aligns component previews and product interfaces with the shared assets, reduces duplicate implementations, and makes icon updates visible during development.

Verification

The following results were recorded before the latest rebase. The rebased commit has an identical patch, verified with git range-diff; checks have not been rerun on the current HEAD.

Passed:

  • pnpm run design-system:check
  • pnpm --dir design-system/apps/design-lab run test
  • pnpm --dir src/web-ui exec tsc --noEmit
  • pnpm run theme:visual-contract
  • pnpm --dir src/web-ui exec vitest run --maxWorkers=2 src/flow_chat/components/HarnessProfileSelector.test.tsx src/infrastructure/design-system/IconUsageIntegration.test.tsx src/app/components/NavPanel/navigationIconIntegration.test.ts
    • 3 test files, 21 tests passed.
  • git -c core.safecrlf=false diff --check

Known verification limitations:

  • pnpm run check:web and pnpm run theme:color-audit:all encountered stale MiniApp and native-mobile generated artifacts. Unrelated generated files and governance baselines were not modified.
  • pnpm --dir src/web-ui exec vitest run --maxWorkers=1 src/app/scenes/agents/AgentsScene.test.tsx reported four failures. The same failures were reproduced using the pre-change code.
  • Development endpoints returned updated modules, but manual visual acceptance was not completed.
  • Remote workspace, remote control, Peer Device Mode, and Detached Dispatch were not exercised.

Reviewer Notes

  • Legacy icon names remain supported; new galleries and pickers use canonical names.
  • The balanced profile uses the standard icon while retaining its existing runtime ID.
  • Specialized icons without an equivalent catalog asset remain unchanged.
  • Other FlowChat and main composer behavior are outside this change.
  • No backend APIs, persisted schemas, or data migrations are changed.
  • Please review icon sizing, loading states, mode selection, and asset hot reload in the running application.

Checklist

  • This PR is focused and does not include secrets, temporary prompts, generated scratch files, or unrelated artifacts.
  • Relevant verification is recorded above, or skipped checks are explained.
  • User-facing strings, docs, and locales are updated where applicable.

Update reviewed icon assets and aliases, add NumberBadge, and migrate component previews and product icon usages.

Watch shared UI sources in both dev servers to invalidate stale inline SVG modules, with asset and hot-update regression coverage.
@kev1n77
kev1n77 merged commit 46b37ce into GCWing:1.0.0-explore Aug 31, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant