Repository navigation
Notifications - #114
Merged
Merged
Notifications#114
Conversation
❌ Deploy Preview for able-alliance failed. Why did it fail? →
|
chrisgoggins
approved these changes
Sep 30, 2026
chrisgoggins
left a comment
chrisgoggins
left a comment
Member
There was a problem hiding this comment.
Good work! Handled some merge conflicts on here and also the new emails. Will look into that stale data issue too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #106. Implements real-time toast notifications for ride-related events (assignment, cancellation, etc.) Testing was not very extensive and scoped mostly to cancellation for the draft. Notification appearance will also be modified to match design. Toast and email notifications are dispatched in parallel so failure in one doesn't affect the other, essentially upholding isolation between the processes to prevent blocking.
Note for future sprints: encountered a bug during testing where admin and user side views don't seem to have any hook for re-rendering displayed data when database updates are made. Not a correctness issue, but means users may see stale data until reload.
Checklist