Skip to content

Add Tests - #115

Merged
chrisgoggins merged 5 commits into
mainfrom
luciano/more-tests
Sep 30, 2026
Merged

chrisgoggins merged 5 commits into
mainfrom
luciano/more-tests

Conversation

@ludafieno

@ludafieno ludafieno commented Sep 22, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Resolves #110

Checklist

  • Title is the same as the ticket title
  • Ticket is mentioned above
  • Changes fulfill the ticket's acceptance criteria
  • Relevant developers have been assigned
  • Relevant reviewers (EM, Designers, etc.) have been requested

@netlify

netlify Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for able-alliance ready!

Name Link
🔨 Latest commit 8421ce6
🔍 Latest deploy log https://app.netlify.com/projects/able-alliance/deploys/6abc7f27d9daf400088b839d
😎 Deploy Preview https://deploy-preview-115--able-alliance.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@ludafieno
ludafieno marked this pull request as ready for review September 29, 2026 06:22
@greptile-apps

greptile-apps Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Disclaimer: This comment was AI-generated and is not necessarily completely accurate. Please take code comments with a grain of salt.

RetriggerConfidence Score: 5/5

[Low risk] Adds end-to-end test coverage for ride flows.

The PR appears safe to merge based on the reviewed changes.

Summary

The PR separates ride coverage into API and UI journeys for scheduling, completion, cancellation, and no-shows. The latest changes align browser dates with New York time and distinguish the Route C admin row by pickup time.

  • No new actionable issues identified.
  • Review score: 100/100.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Requested] --> B[Scheduled]
  B --> C[En-route]
  C --> D[Picked up]
  D --> E[Completed]
  A --> F[Cancelled by Student]
  C --> G[Missing]
Loading

Reviews (2) · Last reviewed commit: "greptile: timezone, distinguishing value..."

Comment thread tests/e2e/routeC.ui.spec.ts
Comment thread tests/e2e/routeA.ui.spec.ts Outdated
@ludafieno

Copy link
Copy Markdown
Collaborator Author

@greptileai

@chrisgoggins
chrisgoggins merged commit 08802f4 into main Sep 30, 2026
6 checks passed
@chrisgoggins
chrisgoggins deleted the luciano/more-tests branch October 1, 2026 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Tests

2 participants