Repository navigation
Improve WebSocket Server backend + Chat Improvements - #99
Merged
Merged
Conversation
✅ Deploy Preview for able-alliance ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Closed
9 tasks
chrisgoggins
requested changes
Sep 15, 2026
Member
There was a problem hiding this comment.
Good work! A few changes regarding to DB model lifecycle:
- Create the active chat record in Next.js (instead of the WebSocket server) when a driver is assigned and the ride transitions from Requested to Scheduled
- Archive the chat in the Next.js route actions when the ride transitions to Completed, Missing, or a cancellation status (relates to next bullet point)
- Rename the WebSocket event from
endRoutetocloseRouteRoom. Also it should only broadcast routeClosed and disconnect the room, with no database writes
This moves important database actions outside of the WebSocket server which is preserved since WebSockets are more error prone
chrisgoggins
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #93 + #97. Splits the single index.mjs into different modules, redacts chat contents from production logs behind NODE_ENV, and sanitizes client-facing socket errors while logging full details server-side. Replaces the in-memory chat map with a MongoDB-backed chat record per ride.
Checklist