Alex/150 table component

[alexdcdc]

Description

Resolves #150

Tracking refactor as I go

• src/screens/DonorOffersScreens/PartnerDynamicDonorOfferScreen.tsx

• src/screens/DonorOffersScreens/AdminDynamicDonorOfferScreen.tsx

• src/screens/DonorOffersScreens/PartnerDonorOffersScreen.tsx

• src/screens/DonorOffersScreens/AdminDonorOffersScreen.tsx

• src/screens/DonorOfferLineItemsScreen.tsx

• src/screens/DonorOfferItemRequestsScreen.tsx

• src/app/donorOffers/[donorOfferId]/edit/page.tsx

• src/components/DonorOffers/PreviewTable.tsx

• src/screens/PartnerUnallocatedItemsScreens/UnallocatedItems.tsx

• src/screens/PartnerUnallocatedItemsScreens/MyRequests.tsx

• src/screens/AdminUnallocatedItemsScreen.tsx

• src/app/unallocatedItems/lineItems/page.tsx

• src/app/unallocatedItems/requests/page.tsx

• src/screens/AdminDistributionsScreen.tsx

• src/screens/AdminDistributionsScreen/SignOffsTable.tsx

• src/screens/AdminDistributionsScreen/DistributionTable.tsx

• src/screens/PartnerDistributionsScreenTables/ViewDistributionsOfSignOffScreen/TableOfItemsOfDistributions.tsx

• src/screens/PartnerDistributionsScreenTables/InProgressTable.tsx

• src/screens/PartnerDistributionsScreenTables/CompleteTable.tsx

• src/app/distributions/[partnerId]/addItem/page.tsx

• src/components/CreateSignOff/FinalSignOffTable.tsx

• src/components/CreateSignOff/CreateSignOffTable.tsx

• src/components/ShippingStatusTable.tsx

• src/components/ShippingItemsModal.tsx

• src/app/accountManagement/page.tsx

• src/components/BulkAdd/BulkAddTable.tsx

Checklist

• The ticket is mentioned above
• The changes fulfill the success criteria of the ticket
• The changes were self-reviewed
• A review was requested

[netlify]

✅ Deploy Preview for hope-for-haiti ready!

Name	Link
🔨 Latest commit	afbbd3a
🔍 Latest deploy log	https://app.netlify.com/projects/hope-for-haiti/deploys/68c60e65fa504b000875229d
😎 Deploy Preview	https://deploy-preview-158--hope-for-haiti.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[alexdcdc]

todo (possibly in next tickets):

• fix unit price formatting? currently it only displays as raw decimal

• get horizontal table scrolling to work with context menus: currently if you allow horizontal scrolling on the table the context menu that shows up when you click the options button will get clipped by the table boundaries. have not figured out a fix for that yet.

• bulk add table untested b/c i don't have a sample excel sheet to upload.

can you make sure all the table row onClick effects got preserved in the refactor? i think i got all of them but would love to have a second pair of eyes.

[Sectonic]

Great work overall! This was a tough but needed ticket lol.

[Sectonic]

make all tables standard, so remove the custom styling for header classes and make all tables look how the accountManagement table looks.

[Sectonic]

This doesn't mean remove headerClassName as it could prove beneficial in other ways like dynamic styling, but generally the styling of tables should be standard.

[Sectonic]

If theres any clean way you can also provide styling to a single row, that would be beneficial as well.

[Sectonic]

One other concern I have with the table row onClick is will other onClicks in the row be affected by it? I want to make sure there is a hierarchy of clicks, so if a button inside the row has an onclick it has priority over the row. Also maybe clicking the row itself is not the best UX in general, and that the onclick should be in the first cell of the row.

[alexdcdc]

Child onClick will need to explicitly call e.stopPropagation() to stop the parent onClick from happening, so requires a small extra step but is perfectly doable.