Repository navigation
Renato/162 data model refactor - #172
Merged
Merged
Conversation
❌ Deploy Preview for hope-for-haiti failed. Why did it fail? →
|
Sectonic
reviewed
Sep 19, 2025
Sectonic
left a comment
Sectonic
left a comment
Contributor
There was a problem hiding this comment.
Honestly a good idea to separate concerns might be to make partner a separate model and have all the partner stuff there.
Other than that the model looks good. You can start working on changing the API and services. I would recommend starting at donor offers. Also, the API routes do not follow proper REST fundamentals, so please try to clean up the routes if you see anything off.
Contributor
|
change the GeneralItem quantity to initialQuantity. This represents only the initial amunt a donor thought of sending |
Co-authored-by: Sujal Dhakal <hello@sujaldhakal.dev>
Co-authored-by: Sujal Dhakal <hello@sujaldhakal.dev>
Co-authored-by: Sujal Dhakal <hello@sujaldhakal.dev>
Co-authored-by: Sujal Dhakal <hello@sujaldhakal.dev>
…ood/hope-for-haiti into renato/162-data-model-refactor
Contributor
Author
|
I've removed most of the now-obsolete code. |
renatodellosso
commented
Oct 8, 2025
renatodellosso
left a comment
renatodellosso
left a comment
Contributor
Author
There was a problem hiding this comment.
Self-review done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
API routes and DB schema is done.
Resolves #162
Checklist