Tested/Working Wishlist Population

src/services/generalItemRequestService.ts

@@ -8,6 +8,7 @@ import {
 } from "@/types/api/donorOffer.types";
 import { Filters } from "@/types/api/filter.types";
 import { buildQueryWithPagination, buildWhereFromFilters } from "@/util/table";
+import { WishlistService } from "./wishlistService";
 
 export class GeneralItemRequestService {
   static async getById(id: number) {
@@ -250,6 +251,22 @@ export class GeneralItemRequestService {
       )
     );
 
+    // After persisting final quantities, auto-populate wishlists for any
+    // requests that were not fully fulfilled (finalQuantity < quantity).
+    const unfulfilledUpdates = updates.filter(({ requestId, finalQuantity }) => {
+      const request = requests.find(r => r.id === requestId);
+      return request && finalQuantity < request.quantity;
+    });
+
+    if (unfulfilledUpdates.length > 0) {
+      try {
+        await WishlistService.createUnfulfilledWishlistEntries(unfulfilledUpdates);
+      } catch (error) {
+        // Log but don't fail the bulk update if wishlist creation errors
+        console.error("Failed to create unfulfilled wishlist entries:", error);
+      }
+    }
+
     return results;
   }
 
@@ -279,7 +296,7 @@ export class GeneralItemRequestService {
 
       const previousGeneralItemId = existingRequest.generalItem.id;
 
-      const targetGeneralItem = await tx.generalItem.findUnique({
+      const targetGeneralItem = await tx.generalItem.findFirst({
         where: { id: targetGeneralItemId },
         select: {
           id: true,
@@ -537,4 +554,4 @@ export class GeneralItemRequestService {
       total,
     };
   }
-}
+}

src/services/wishlistService.ts

@@ -11,6 +11,8 @@ import { Prisma } from "@prisma/client";
 import { PrismaClientKnownRequestError } from "@prisma/client/runtime/library";
 import { MatchingService } from "./matchingService";
 
+const AUTO_GENERATED_COMMENT = "Automatically generated due to unfulfilled request";
+
 export class WishlistService {
   static async createWishlist(data: CreateWishlistData) {
     const partner = await db.user.findUnique({
@@ -42,6 +44,92 @@ export class WishlistService {
     return wishlist;
   }
 
+  /**
+   * For each request where finalQuantity < quantity, automatically creates or
+   * updates a wishlist entry for the partner with the unfulfilled quantity.
+   * If an entry with the same name already exists for the partner, the
+   * unfulfilled quantity is added to it.
+   */
+  static async createUnfulfilledWishlistEntries(
+    requests: Array<{
+      requestId: number;
+      finalQuantity: number;
+    }>
+  ): Promise<void> {
+    if (requests.length === 0) return;
+
+    const requestIds = requests.map((r) => r.requestId);
+
+    const fullRequests = await db.generalItemRequest.findMany({
+      where: { id: { in: requestIds } },
+      include: {
+        generalItem: {
+          select: { title: true },
+        },
+        partner: {
+          select: { id: true, enabled: true, pending: true },
+        },
+      },
+    });
+
+    for (const update of requests) {
+      const request = fullRequests.find((r) => r.id === update.requestId);
+      if (!request) continue;
+
+      // Skip inactive partners
+      if (!request.partner.enabled || request.partner.pending) continue;
+
+      const unfulfilledQuantity = request.quantity - update.finalQuantity;
+      if (unfulfilledQuantity <= 0) continue;
+
+      const itemName = request.generalItem.title;
+      const partnerId = request.partner.id;
+      const priority = request.priority ?? "LOW";
+
+      // Check if a wishlist entry with the same name already exists
+      const existing = await db.wishlist.findFirst({
+        where: {
+          partnerId,
+          name: itemName,
+          generalItemId: null, // only unfulfilled wishlist entries
+        },
+      });
+
+      if (existing) {
+        // Add quantities together
+        await db.wishlist.update({
+          where: { id: existing.id },
+          data: {
+            quantity: (existing.quantity ?? 0) + unfulfilledQuantity,
+          },
+        });
+      } else {
+        // Create a new wishlist entry
+        const wishlist = await db.wishlist.create({
+          data: {
+            name: itemName,
+            quantity: unfulfilledQuantity,
+            priority,
+            comments: AUTO_GENERATED_COMMENT,
+            partnerId,
+          },
+        });
+
+        try {
+          await MatchingService.add({
+            wishlistId: wishlist.id,
+            title: wishlist.name,
+          });
+        } catch (error) {
+          console.warn(
+            "Failed to generate embedding for auto-created wishlist entry:",
+            error
+          );
+        }
+      }
+    }
+  }
+
   /**
    * Automatically updates lastUpdated
    */
@@ -247,4 +335,4 @@ export class WishlistService {
       }
     }
   }
-}
+}