Nathan/donor offer bugs

[ND68]

Description

Resolves ticket number: #327 & #330

Explain what your code changes: Removed create donor offer button from finalized and archived tabs. Added date validation create donor offer screen.

List the steps you took to test your code: Visually confirmed and tested invalid dates.

Checklist

• [ x] The ticket is mentioned above
• [ x] The changes fulfill the success criteria of the ticket
• [ x] The changes were self-reviewed
• [ x] A review was requested

[netlify]

✅ Deploy Preview for hope-for-haiti ready!

Name	Link
🔨 Latest commit	9ef185c
🔍 Latest deploy log	https://app.netlify.com/projects/hope-for-haiti/deploys/69dda4690a2fa30008dafb66
😎 Deploy Preview	https://deploy-preview-341--hope-for-haiti.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[greptile-apps]

Greptile Summary

This PR fixes two bugs: it hides the "Create Donor Offer" button on the Finalized and Archived tabs, and adds client-side validation to prevent past deadlines when creating a donor offer.

• Date validation bypass (P1): The new past-date checks live only in validateBeforeUpload, which fires on file selection. After the file is uploaded, both date inputs remain editable and neither showPreview nor handleSubmit re-validates them, so a user can upload with valid dates, change them to past dates, and still create the offer.

Confidence Score: 4/5

Safe to merge after fixing the date-validation bypass in handleSubmit; the tab-button fix is correct as-is.

One P1 finding: the new date validation is applied only at file-upload time and can be trivially bypassed by editing dates afterward, defeating the stated goal of the PR. The tab-button change is clean and correct.

src/app/donorOffers/create/page.tsx — handleSubmit needs the same date guard that was added to validateBeforeUpload.

Important Files Changed

Filename	Overview
src/app/donorOffers/create/page.tsx	Adds date-in-the-past validation inside validateBeforeUpload (file-select callback only); handleSubmit and showPreview do not re-validate, so changed dates after a successful upload bypass the new guard entirely.
src/screens/DonorOffersScreens/AdminDonorOffersScreen.tsx	Correctly hides the "Create Donor Offer" button on Finalized and Archived tabs by adding the activeTab === StatusFilterKey.UNFINALIZED guard.

Sequence Diagram

sequenceDiagram
    actor User
    participant Form as CreateDonorOfferPage
    participant Upload as useFileUpload
    participant API as /api/donorOffers

    User->>Form: Fill in offerName, donorName, deadlines
    User->>Form: Select file
    Form->>Upload: handleFileChange()
    Upload->>Upload: validateBeforeUpload() ✅ date check here
    alt Validation fails (past date)
        Upload-->>Form: Return errors
        Form-->>User: Show error messages
    else Validation passes
        Upload->>API: POST /api/donorOffers?preview=true
        API-->>Upload: Preview data
        Upload-->>Form: fileUploaded = true
    end
    Note over User,Form: ⚠️ User can now freely edit date fields
    User->>Form: Optionally change dates to past
    User->>Form: Click Preview Offer
    Form->>Form: showPreview() — no date re-validation
    Form-->>User: Show preview table
    User->>Form: Click Create Offer
    Form->>Form: handleSubmit() — no date validation ❌
    Form->>API: POST /api/donorOffers (possibly with past dates)
    API-->>Form: Success/Error

Loading

Comments Outside Diff (1)

1. src/app/donorOffers/create/page.tsx, line 126-150 (link)

   Date validation can be bypassed after file upload

   validateBeforeUpload runs only when the file is selected. After a file is successfully uploaded with valid future dates, the user can freely edit the date inputs and then click Preview Offer → Create Offer without those changed dates ever being re-checked. showPreview only guards on fileUploaded/fileErrorMessage, and handleSubmit contains no date validation at all, so a past-date offer can be submitted despite the new guards.

_{Reviews (1): Last reviewed commit: "date validatino on donor offers" | Re-trigger Greptile}

[greptile-apps]

getTodayDateString should be a module-level utility

This function doesn't close over any component state or props, so defining it inside the component creates a new function reference on every render. Move it outside the component (or to a shared utility file).

Suggested change

	const getTodayDateString = () => {
	const date = new Date();
	const year = date.getFullYear();
	const month = String(date.getMonth() + 1).padStart(2, '0');
	const day = String(date.getDate()).padStart(2, '0');
	return `${year}-${month}-${day}`;
	};
	const getTodayDateString = () => {
	const date = new Date();
	const year = date.getFullYear();
	const month = String(date.getMonth() + 1).padStart(2, '0');
	const day = String(date.getDate()).padStart(2, '0');
	return `${year}-${month}-${day}`;
	};
	export default function CreateDonorOfferPage() {