Gia2/UI inconsistencies

[giannacastr]

Description

Resolves ticket number: #338

Explain what your code changes:
Fixes the headers for all pages for both partners and admin to be consistent between pages.

List the steps you took to test your code:
I switched through the different account types and pages. I took pictures between tabs to make sure headers were the same between pages.

Checklist

• The ticket is mentioned above
• The changes fulfill the success criteria of the ticket
• The changes were self-reviewed
• A review was requested

[netlify]

✅ Deploy Preview for hope-for-haiti ready!

Name	Link
🔨 Latest commit	cdef46f
🔍 Latest deploy log	https://app.netlify.com/projects/hope-for-haiti/deploys/69de5d1ce009180007dba894
😎 Deploy Preview	https://deploy-preview-346--hope-for-haiti.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[greptile-apps]

Greptile Summary

This PR standardizes page headers across admin and partner screens by unifying font weight (font-semibold), removing hardcoded sizes/colors, and aligning spacing. The fixes are largely correct, but the implementation uses empty <div className="h-4"></div> spacer elements in five places rather than padding or flex gap, which goes against the project's own checklist guideline ("Uses flex gaps and paddings instead of margins wherever possible").

Confidence Score: 5/5

• Safe to merge — all findings are style/quality suggestions with no functional impact.
• All remaining issues are P2: spacer divs instead of padding/gap and redundant flex wrappers. No logic, data, or security concerns exist in this UI-only consistency pass.
• src/screens/Wishlist/PartnerWishlistScreen.tsx has an inconsistent spacer-before-header pattern with a negative margin that differs from every other changed file.

Important Files Changed

Filename	Overview
src/app/accountManagement/page.tsx	Adds m-0 to h1 and inserts an empty spacer div to create header spacing — use padding/gap instead per project guidelines.
src/components/dashboard/FloatingNotification.tsx	Adjusts the notification bell from top-9 to top-7 to align with the updated header layout — simple, safe change.
src/screens/AdminUnallocatedItemsScreen.tsx	Adds m-0 to h1 and inserts an empty spacer div — same spacer-div concern as other files.
src/screens/PartnerItemsScreen.tsx	Removes top padding, wraps h1 in a redundant single-child flex div, and adds a spacer div instead of using padding/gap.
src/screens/PartnerRequestsScreen.tsx	Same pattern as PartnerItemsScreen — removes top padding, redundant flex wrapper, spacer div used for spacing.
src/screens/ProfileScreenPartner.tsx	Correctly replaces hardcoded text-[#22070B] color and text-[32px] with Tailwind config classes; redundant single-child flex wrapper added.
src/screens/Wishlist/AdminWishlistScreen.tsx	Changes font-bold to font-semibold to match other screen headers — correct and minimal change.
src/screens/Wishlist/PartnerWishlistScreen.tsx	Spacer placed before the header (opposite of all other screens), combined with m-0 -mt-3 negative margin — inconsistent with the rest of the PR's approach.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Page/Screen renders] --> B{Screen type?}
    B -->|Admin| C[AdminUnallocatedItemsScreen\nAdminWishlistScreen\nAccountManagement]
    B -->|Partner| D[PartnerItemsScreen\nPartnerRequestsScreen\nPartnerWishlistScreen\nProfileScreenPartner]
    C --> E["h1: text-2xl font-semibold text-gray-primary m-0"]
    D --> F["h1: text-2xl font-semibold text-gray-primary m-0"]
    E --> G["spacer div h-4 after heading"]
    F --> G
    G --> H[Table / Content]

    I[FloatingNotification] --> J["Position adjusted: top-9 → top-7"]

Loading

_{Reviews (1): Last reviewed commit: "undid tutorial local adjustment" | Re-trigger Greptile}

[greptile-apps]

Inconsistent spacing approach and redundant negative margin

A h-4 spacer div (16px) is placed before the header, then m-0 -mt-3 is applied to the h1 — effectively reducing the spacing to 4px. Every other screen in this PR places the spacer after the heading and doesn't use negative margins. This inconsistency undermines the consistency goal of the ticket.

Suggested change

	<div className="h-4"></div>
	<div className="flex items-start justify-between">
	<h1 className="text-2xl font-semibold text-gray-primary mb-2">
	Wishlist
	<h1 className="text-2xl font-semibold text-gray-primary m-0 -mt-3">
	My Wishlist
	</h1>
	<div className="flex items-start justify-between">
	<h1 className="text-2xl font-semibold text-gray-primary m-0">
	My Wishlist
	</h1>
	</div>
	<div className="h-4"></div>

Context Used: Fill out this checklist in addition to code commen... (source)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

[greptile-apps]

Spacer div instead of padding/gap; redundant flex wrapper

The project checklist requires using flex gaps and paddings instead of spacer elements. The <div className="h-4"> should be replaced with pt-4 on the AdvancedBaseTable's wrapper or gap-4 on a flex parent. The same pattern appears in AccountManagement, AdminUnallocatedItems, PartnerRequests, and PartnerWishlist — all five instances should be changed.

Additionally, the flex items-start justify-between wrapper div has only one child (h1), making the flex layout redundant. The same occurs in PartnerRequestsScreen.tsx and ProfileScreenPartner.tsx.

Context Used: Fill out this checklist in addition to code commen... (source)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!