Skip to content

Add ability to delete a file config - #63

Merged
llam36 merged 7 commits into
mainfrom
long/delete-file-config
Feb 9, 2026
Merged

llam36 merged 7 commits into
mainfrom
long/delete-file-config

Conversation

@llam36

@llam36 llam36 commented Nov 16, 2025

Copy link
Copy Markdown
Collaborator

Add ability to delete a file config

  • Updated SDK internal folder
  • Expose deleteFileConfig method

@greptile-apps

greptile-apps Bot commented Nov 16, 2025 •

Copy link
Copy Markdown
Contributor

Disclaimer: This comment was AI-generated and is not necessarily completely accurate. Please take code comments with a grain of salt.

Greptile Summary

  • Added deleteConfig method to FileAPI for deleting file configurations by project ID
  • Removed SettingsAPI class and migrated its methods to respective API classes (EmailAPI and FileAPI)
  • Updated internal SDK files with correct DELETE HTTP method and reorganized imports

Confidence Score: 2/5

  • This PR should not be merged yet due to an accidentally committed file
  • Score reflects one critical issue: src/internal/package.json from the backend API repository was accidentally committed and must be removed. The core functionality (delete file config) is properly implemented with correct HTTP method usage
  • Remove src/internal/package.json before merging

Important Files Changed

Filename Overview
src/internal/api/fileConfigApi.ts Added fileConfigControllerDeleteFileConfigByProjectId method using DELETE HTTP method correctly
src/lib/file.ts Added deleteConfig method and updated getConfig method signature, renamed from getConfigByProjectId
src/internal/package.json Added package.json from internal API repository (appears to be unintentionally committed)

Sequence Diagram

sequenceDiagram
    participant User
    participant SDK as "Juno SDK"
    participant FileAPI as "FileAPI"
    participant ConfigApi as "FileConfigApi"
    participant Backend as "Backend API"
    
    User->>SDK: "juno.file.deleteConfig(projectId, credentials)"
    SDK->>FileAPI: "deleteConfig(projectId, credentials)"
    FileAPI->>FileAPI: "Build headers with JWT and projectId"
    FileAPI->>ConfigApi: "fileConfigControllerDeleteFileConfigByProjectId(projectId, {headers})"
    ConfigApi->>ConfigApi: "Validate projectId"
    ConfigApi->>ConfigApi: "Apply authentication"
    ConfigApi->>Backend: "DELETE /file/config/delete/{projectId}"
    Backend-->>ConfigApi: "FileConfigResponse"
    ConfigApi-->>FileAPI: "response.body"
    FileAPI-->>SDK: "FileConfigResponse"
    SDK-->>User: "FileConfigResponse"
Loading

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

Comment thread src/internal/api/fileConfigApi.ts Outdated
@llam36
llam36 marked this pull request as draft November 16, 2025 19:12
@llam36
llam36 marked this pull request as ready for review November 16, 2025 19:12

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format

Comment thread src/internal/package.json Outdated
@llam36
llam36 requested a review from UZ9 November 18, 2025 05:38
@llam36
llam36 requested a review from shaply January 28, 2026 20:07
@llam36
llam36 merged commit 6812c61 into main Feb 9, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant