Fix minor bug where invalid password triggered sentry (#229)

Author: UZ9

packages/db-service/src/modules/user/user.controller.ts

@@ -51,6 +51,14 @@ export class UserController implements UserProto.UserServiceController {
   ): Promise<UserProto.UserPasswordHash> {
     const userFind = validate.validateUserIdentifier(identifier);
     const user = await this.userService.user(userFind);
+
+    if (!user) {
+      throw new RpcException({
+        code: status.NOT_FOUND,
+        message: 'User not found',
+      });
+    }
+
     return {
       hash: user.password,
     };

packages/db-service/test/user.e2e-spec.ts

@@ -434,6 +434,42 @@ describe('DB Service User Tests', () => {
     await getUserPasswordHashPromise;
   });
 
+  it('throws NOT_FOUND error when getting password hash for non-existent user by email', async () => {
+    const promise = new Promise((resolve) => {
+      userClient.getUserPasswordHash(
+        {
+          email: 'nonexistent@test.com',
+        },
+        (err) => {
+          expect(err).toBeDefined();
+          expect(err.code).toBe(GRPC.status.NOT_FOUND);
+          expect(err.details).toBe('User not found');
+          resolve({});
+        },
+      );
+    });
+
+    await promise;
+  });
+
+  it('throws NOT_FOUND error when getting password hash for non-existent user by id', async () => {
+    const promise = new Promise((resolve) => {
+      userClient.getUserPasswordHash(
+        {
+          id: 99999,
+        },
+        (err) => {
+          expect(err).toBeDefined();
+          expect(err.code).toBe(GRPC.status.NOT_FOUND);
+          expect(err.details).toBe('User not found');
+          resolve({});
+        },
+      );
+    });
+
+    await promise;
+  });
+
   it('throws an error when both id and email are provided', async () => {
     const promise = new Promise((resolve) => {
       userClient.updateUser(