Repository navigation
file services bucket tagging + file service config setup - #200
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Disclaimer: This comment was AI-generated and is not necessarily completely accurate. Please take code comments with a grain of salt.
PR Summary
This PR introduces a new file service configuration setup endpoint and corresponding changes across microservices, including new DTOs, updated bucket naming conventions, and additional e2e tests to validate the new functionality.
- /packages/api-gateway/src/modules/file_config/file_config.controller.ts: Added POST '/config/setup' endpoint (note typo in the summary text).
- /packages/api-gateway/src/modules/file_config/file_config.module.ts: Registered new gRPC client using FILE_SERVICE_ADDR.
- /packages/api-gateway/src/models/file_config.dto.ts: Introduced SetupFileServiceResponse DTO.
- /packages/file-service/src/modules/file_config/file_config.service.ts: Implements setup via gRPC.
- S3/Azure handlers: Updated bucket naming to include configId and configEnv; ensure naming complies with provider requirements.
Score: 95
17 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
…oller.ts Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
llam36
requested changes
Sep 13, 2025
llam36
self-requested a review
September 14, 2025 04:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.