Skip to content

file services bucket tagging + file service config setup - #200

Merged
UZ9 merged 10 commits into
mainfrom
tejas/file-service-config-bucket-tag
Sep 23, 2025
Merged

UZ9 merged 10 commits into
mainfrom
tejas/file-service-config-bucket-tag

Conversation

@tmthecoder

Copy link
Copy Markdown
Contributor

No description provided.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disclaimer: This comment was AI-generated and is not necessarily completely accurate. Please take code comments with a grain of salt.

PR Summary

This PR introduces a new file service configuration setup endpoint and corresponding changes across microservices, including new DTOs, updated bucket naming conventions, and additional e2e tests to validate the new functionality.

  • /packages/api-gateway/src/modules/file_config/file_config.controller.ts: Added POST '/config/setup' endpoint (note typo in the summary text).
  • /packages/api-gateway/src/modules/file_config/file_config.module.ts: Registered new gRPC client using FILE_SERVICE_ADDR.
  • /packages/api-gateway/src/models/file_config.dto.ts: Introduced SetupFileServiceResponse DTO.
  • /packages/file-service/src/modules/file_config/file_config.service.ts: Implements setup via gRPC.
  • S3/Azure handlers: Updated bucket naming to include configId and configEnv; ensure naming complies with provider requirements.

Score: 95

17 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile

Comment thread packages/api-gateway/src/models/file_config.dto.ts
Comment thread packages/file-service/test/file_config.e2e-spec.ts
@UZ9 UZ9 assigned UZ9 and llam36 Sep 9, 2025
…oller.ts

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Comment thread packages/api-gateway/test/file_config.e2e-spec.ts
Comment thread packages/file-service/src/modules/file_upload/azure_handler.ts
Comment thread packages/file-service/src/modules/file_upload/s3_handler.ts
@llam36
llam36 self-requested a review September 14, 2025 04:18

@llam36 llam36 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@llam36
llam36 requested a review from UZ9 September 14, 2025 04:19
@UZ9
UZ9 merged commit 71a41e8 into main Sep 23, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants