Davidgu/safeguard for email/password jwt generation route

[shaply]

Not a huge concern, but there currently isn't a guardrail for valid email/password but deleted user entry. The exception is still caught before returning to the user, but not before emitting an error metric in Sentry.

Fix

• Add safeguard for invalid user when performing lookup via prisma in authenticate

Testing

• Additional test in DB Service validating authenticate correctly catches invalid prisma return
  Created the test in Auth-service.

authenticate now no longer logs a not found error and logs any other error from db service and throws an unknown error when that happens.

[greptile-apps]

Disclaimer: This comment was AI-generated and is not necessarily completely accurate. Please take code comments with a grain of salt.

Greptile Summary

• Improved error handling in authenticate to differentiate expected NOT_FOUND errors (invalid/deleted users) from unexpected errors, preventing unnecessary Sentry alerts
• Added comprehensive test coverage for deleted user authentication in both auth-service and db-service test suites

Confidence Score: 4/5

• This PR is safe to merge with low risk
• The changes improve error handling by preventing unnecessary Sentry logging for expected authentication failures. The logic correctly differentiates between NOT_FOUND (expected) and other errors (unexpected). However, there's a potential edge case where getUser at line 62-66 could fail if a user is deleted between password verification and final user retrieval, but this race condition is unlikely and would be caught by existing error handling.
• No files require special attention

Important Files Changed

Filename	Overview
packages/auth-service/src/modules/user/user.controller.ts	Improved error handling to differentiate NOT_FOUND from unexpected errors, preventing unnecessary Sentry logs for expected authentication failures

Sequence Diagram

sequenceDiagram
    participant User
    participant AuthService
    participant DBService
    
    User->>AuthService: authenticate(email, password)
    AuthService->>DBService: getUserPasswordHash(email)
    alt User not found or deleted
        DBService-->>AuthService: NOT_FOUND error
        AuthService-->>User: NOT_FOUND error
    else User exists
        DBService-->>AuthService: passwordHash
        AuthService->>AuthService: bcrypt.compare(password, hash)
        alt Password incorrect
            AuthService-->>User: PERMISSION_DENIED error
        else Password correct
            AuthService->>DBService: getUser(email)
            DBService-->>AuthService: User object
            AuthService-->>User: User object
        end
    end

Loading

[greptile-apps]

_{3 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format}

[llam36]

LGTM!