Skip to content

davidgu/update_package.json - #241

Closed
shaply wants to merge 1 commit into
mainfrom
davidgu/update_typescript-node_to_typescript-fetch
Closed

shaply wants to merge 1 commit into
mainfrom
davidgu/update_typescript-node_to_typescript-fetch

Conversation

@shaply

@shaply shaply commented Feb 20, 2026

Copy link
Copy Markdown
Contributor

For the juno-sdk ticket where we need to update to not use the request library anymore.

@shaply
shaply requested a review from llam36 February 20, 2026 04:07
@shaply shaply changed the title Updated package.json davidgu/update_package.json Feb 20, 2026
@greptile-apps

greptile-apps Bot commented Feb 20, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Updated the OpenAPI generator from typescript-node to typescript-fetch in the SDK generation script. The typescript-node generator uses the deprecated request library (deprecated since 2020 with known security vulnerabilities), while typescript-fetch uses the modern native fetch API.

Key changes:

  • Modified the -g flag in the gen-client-sdk script from typescript-node to typescript-fetch
  • This affects the auto-generated SDK published on releases via the GitHub Action workflow
  • Consumers of the SDK will need to update their usage as the generated API will have different interfaces

Note: The generated SDK API surface will change - existing consumers using the typescript-node generated SDK will need to migrate to the new typescript-fetch API patterns when they update to the new SDK version.

Confidence Score: 5/5

  • This PR is safe to merge - it's a single-line configuration change that addresses a real deprecation issue
  • The change updates from a deprecated generator to a modern one, addressing security concerns with the request library. It's a configuration-only change with no logic modifications.
  • No files require special attention

Important Files Changed

Filename Overview
package.json Changed OpenAPI generator from deprecated typescript-node (uses request library) to modern typescript-fetch (uses native fetch API)

Last reviewed commit: d18eec0

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@shaply shaply closed this Mar 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant