Don't duplicate seeded notifications when the seed reruns

Seeded notifications get random IDs, so onConflictDoNothing never
matched and every rerun of pnpm run db:seed inserted another copy,
doubling each user's unread count. The Visionaries doc tells existing
contributors to rerun the seed, so skip templates the user already has
in that organization. This also keeps databases seeded before this
change from gaining another copy.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EsE8hW2Sa81QXuqHAStNNa

Author: claude

scripts/seed.ts

@@ -580,15 +580,31 @@ export async function main() {
 
   for (const email of memberEmails) {
     for (const org of ORGS) {
-      const notificationValues = notificationTemplates.map((tmpl) => ({
-        id: randomUUID(),
-        userId: userIdsByOrganization.get(org.id)!.get(email)!,
-        organizationId: org.id,
-        type: tmpl.type,
-        text: tmpl.text,
-        read: tmpl.read,
-        createdAt: new Date(Date.now() - tmpl.minutesAgo * 60 * 1000),
-      }));
+      const userId = userIdsByOrganization.get(org.id)!.get(email)!;
+      // Skip the ones an earlier run created. Their IDs are random, so
+      // onConflictDoNothing alone would insert a second copy.
+      const existing = await db
+        .select({ text: schema.notifications.text })
+        .from(schema.notifications)
+        .where(
+          and(
+            eq(schema.notifications.userId, userId),
+            eq(schema.notifications.organizationId, org.id),
+          ),
+        );
+      const existingTexts = new Set(existing.map((row) => row.text));
+      const notificationValues = notificationTemplates
+        .filter((tmpl) => !existingTexts.has(tmpl.text))
+        .map((tmpl) => ({
+          id: randomUUID(),
+          userId,
+          organizationId: org.id,
+          type: tmpl.type,
+          text: tmpl.text,
+          read: tmpl.read,
+          createdAt: new Date(Date.now() - tmpl.minutesAgo * 60 * 1000),
+        }));
+      if (notificationValues.length === 0) continue;
 
       await db
         .insert(schema.notifications)

tests/unit/scripts/seed.test.ts

@@ -13,12 +13,13 @@ import {
   formComponents,
   FormStatus,
   MemberType,
+  notifications,
 } from "@/lib/schema";
 import { FormDefinitionSchema } from "@/lib/forms/schema";
 import { OrganizationConfigService } from "@/lib/services/OrganizationConfigService";
 import { hashPassword } from "better-auth/crypto";
 import { main } from "@/scripts/seed";
-import { and, asc, eq, isNull } from "drizzle-orm";
+import { and, asc, count, eq, isNull } from "drizzle-orm";
 import { expect, it } from "vitest";
 import {
   createForm,
@@ -54,6 +55,16 @@ it("should not create duplicate organizations on multiple runs", async () => {
   expect(orgs.length).toBe(1); // Only one organization with the slug 'servicestart' should exist
 });
 
+it("doesn't duplicate notifications on multiple runs", async () => {
+  await main();
+  const [first] = await db.select({ count: count() }).from(notifications);
+  await main();
+  const [second] = await db.select({ count: count() }).from(notifications);
+
+  expect(first.count).toBeGreaterThan(0);
+  expect(second.count).toBe(first.count);
+});
+
 it("creates users/accounts such that they can be signed into", async () => {
   await main();