Repository navigation
Combine auth page branding, logos, and missing-organization handling - #272
Merged
Merged
Conversation
A failed organization config request was parsed and rendered as though it were valid configuration, and cached for five minutes, so a visitor on a subdomain with no matching organization got a page that looked broken with no explanation. - Return 404 rather than 400 for a missing organization, so missing, malformed and server-error are distinguishable by status alone - Check res.ok before parsing, and never write a non-ok response to the cache - Add an additive status field to useOrganizationConfig so callers can tell "no such nonprofit" apart from a network or server failure - Bump the config cache key prefix to retire entries poisoned by the old bug - Render a shared, unbranded OrganizationNotFound on the four auth pages
The hook tests covered every status, but nothing asserted the four auth pages actually render OrganizationNotFound -- deleting the early return from a page left the suite green. Covers all four pages against not-found, ok and error.
✅ Deploy Preview for servicestart ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
shaply
commented
Sep 14, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combines #262, #266, and #268 because they conflict pairwise across login, signup, forgot password, and reset password. Preserves all source commits and resolves the pages together: one public configuration request includes LogoUrl, shared color defaults, normalized logo/tagline rendering, and the terminal missing-organization guard.
The integration also fixes the review findings: successful hook fixtures now include HTTP status and run with cache cleanup, and browser Hono RPC requests use the visited tenant's origin while server requests retain the configured absolute URL. Added real-response browser tests covering all four pages on two missing tenant subdomains with one server configuration. Main's newer health-checked CI database service is retained.
Checked every currently open PR's changed files: no additional PR touches these four pages. #270 changes related authenticated redirect handling in other pages and remains separate. The source PRs remain open; this PR supersedes them.
Validation:
Closes #252
Closes #253
Closes #254