Complete the admin email sending flow by jlouisugbo · Pull Request #285 · GTBitsOfGood/servicestart

jlouisugbo · 2026-09-24T18:56:20Z

Closes #99

Checklist:

I have mentioned a ticket above
My changes meet the acceptance criteria of said ticket
I have self-reviewed my changes
I have requested a review from the appropriate team member(s)
I have fixed all merge conflicts
I have ensured CI checks pass

Description

Admins and owners can compose an email from the inbox, choose recipients in the active organization, and see whether the send succeeded or failed. An empty recipient list is rejected instead of mailing the whole organization. While a send is in flight the composer stays open and cannot be submitted again. A failed send keeps the draft so it can be retried.

Changes Made

Inbox New + is limited to admins and owners and opens the send-email composer.
Recipient lists page through the members API so organizations with more than 100 members are fully selectable.
Subject, body, and at least one recipient are required. Recipients outside the active organization are excluded, and a selection with nobody in the organization is rejected.
Sending shows a pending state and blocks closing or submitting again. The composer closes and confirms only after a successful response. A failure keeps the subject, body, recipients, and error so the send can be retried.
POST /api/emails enforces admin access, validation, and tenant isolation. Unit and end-to-end tests cover those cases, plus member, guest, pending, and owner viewpoints.

Screenshots/Videos

Admin sends successfully

admin-sends-successfully.webm

Failed send, draft stays, then retry

failed-send-retry.webm

Member sees the inbox with no New button

member-no-new.webm

Guest is sent to login

guest-to-login.webm

Pending join request is sent away from the inbox

pending-join.webm

Owner opens the composer

owner-opens-composer.webm

Teammate is listed and a member of another organization is not

teammate-not-other-org.webm

QA Steps

Sign in as an organization admin and open Inbox.
Confirm New + opens the composer. Submit with no recipient selected and confirm the form stays open with a validation message.
Select a member, enter a subject and body, and send. Confirm the button shows Sending..., the dialog stays open while the request is in flight, then the modal closes and an Email sent banner appears.
Force a send failure. Confirm the subject, body, and selected recipient remain, the error is shown, and a second send can succeed.
Sign in as a member who is not an admin and confirm New + is absent. Open /inbox signed out and confirm the login page. Open it with a pending join request and confirm the join-request status page.
Sign in as an owner and confirm the composer opens. Confirm a teammate appears in the recipient picker and a member of another organization does not.
With more than 100 members, confirm a member past the first page can be selected.

Related Tickets

Build and integrate the reusable email editor #100 reusable email editor. Subtitle and footer are included in the plain-text body so they are not discarded.
BUG: Email sending wipe #271 closing the composer while a send is in flight.

Empty recipient lists no longer fall through to the whole organization, and send success or failure stays visible in the composer.

Keep the admin send rules and the success toast from main.

netlify · 2026-09-25T15:41:08Z

❌ Deploy Preview for servicestart failed. Why did it fail? →

Name	Link
🔨 Latest commit	`61ace38`
🔍 Latest deploy log	https://app.netlify.com/projects/servicestart/deploys/6ab5725c2deee8000841dbcf

netlify · 2026-09-25T15:41:09Z

✅ Deploy Preview for servicestart ready!

Name	Link
🔨 Latest commit	`2ebcbd5`
🔍 Latest deploy log	https://app.netlify.com/projects/servicestart/deploys/6abb0d860833f80008977a61
😎 Deploy Preview	https://deploy-preview-285--servicestart.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
🤖 Make changes	Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

shaply · 2026-09-26T18:01:15Z

@greptileai

greptile-apps · 2026-09-26T18:05:43Z

Disclaimer: This comment was AI-generated and is not necessarily completely accurate. Please take code comments with a grain of salt.

Confidence Score: 3/5

[Medium risk] Completes the admin email sending feature with validation and error handling.

The PR is not ready to merge until authentication precedence, persistence after delivery failure, and the explicit modal-styling requirement are addressed.

Findings

Invalid requests bypass authentication ▶
Failed delivery leaves saved records ▶
Deletion modals violate typography requirements ▶

Summary

The PR adds an admin email composer, paginated recipient selection, tenant-scoped sending, delivery feedback, and tests.

Improve authentication-before-validation ordering and coordinate delivery failures with persisted announcements and messages.
Update the changed deletion-modal typography and colors to meet the repository’s modal requirement.
Checklist areas needing improvement: API status codes, handling failed backend operations after database writes, and modal styling. Review score: 70/100.

Diagram

sequenceDiagram
  participant Admin
  participant Composer
  participant API
  participant EmailService
  participant Provider
  Admin->>Composer: Select recipients and compose
  Composer->>API: POST /api/emails
  API->>EmailService: Send to active-organization members
  EmailService->>Provider: Send email
  Provider-->>EmailService: Delivery result
  EmailService-->>API: Success or failure
  API-->>Composer: Response
  Composer-->>Admin: Confirmation or retained draft

_{Reviews (1) · Last reviewed commit: "Merge origin/main into joel/admin-email-..."}

greptile-apps · 2026-09-26T18:05:46Z

+  zValidator("json", sendEmailSchema, (result, c) => {
+    if (!result.success) {
+      return c.json(
+        { error: result.error.issues[0]?.message ?? "Invalid email" },
+        400,
+      );
+    }


Invalid requests bypass authentication

When a signed-out caller submits an empty recipient list or a whitespace-only subject, this callback returns 400 before requireAdmin runs. The request should receive 401 instead; an empty-recipient request previously reached that authentication check.

greptile-apps · 2026-09-26T18:05:46Z

+  if (!result.success) {
+    throw new Error("Failed to send email");
+  }


Failed delivery leaves saved records

If the email provider returns success: false, this new throw reaches the announcement and message callers after they have saved their records. Their requests then fail even though the records remain: retrying publication cannot resend an already-published announcement, and retrying message creation risks duplicate work. Delivery failure needs to be handled together with those writes.

greptile-apps · 2026-09-26T18:05:46Z

+          <p className="text-desktop-paragraph-2! leading-5.5! font-bold! font-paragraph! text-grey-text-strong">
            Please Confirm Deletion
          </p>
        }
        description={
-          <p className="!text-mobile-paragraph-2 !leading-[20px] !font-paragraph text-grey-text-weak">
+          <p className="text-mobile-paragraph-2! leading-5! font-paragraph! text-grey-text-weak">


Deletion modals violate typography requirements

The changed title and description classes use paragraph styles and grey text. The repository requires modal titles to use responsive heading-1 variables, descriptions to use paragraph-1 variables, and both to use white text. The batch-deletion modal repeats this pattern; this requirement must be satisfied before merging.

Rule Used: Modal titles should use the heading-1 CSS variables from src/styles/globals.css for font-size, font-family, and line-height (responsive for desktop and mobile). Modal descriptions should use the paragraph-1 CSS variables from the same file. Bot... (source)

Learned From
GTBitsOfGood/design-system#76

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

emailMembers now threw when Juno reported an unsuccessful send, which turned announcement publishing and message creation into 500s after their rows were already saved. Return a result (sent, no-recipients, delivery-failed) instead, and let POST /api/emails map it to 400/500. Other callers keep their previous behavior. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VeYmbN1aRFTdeZM8vU2cC3

shaply · 2026-09-28T16:25:00Z

Pushed c055fa8 for Greptile's P1 "Failed delivery leaves saved records". EmailService.emailMembers threw on an unsuccessful Juno result, so announcement publishing and message creation would have returned 500 after their rows were already saved. It now returns "sent" | "no-recipients" | "delivery-failed". POST /api/emails maps those to 200/400/500 (the same statuses as before), and the other callers keep their previous behavior. Added a service test for the failed-delivery case.

Left as-is:

"Invalid requests bypass authentication": validating before requireAdmin matches every other route in api/, and a 400 for a malformed body reveals nothing.
Modal typography (P2): that rule comes from the design-system repo. White text on these white dialogs would be unreadable.

Generated by Claude Code

jlouisugbo added 2 commits September 24, 2026 14:55

feat(inbox): let admins compose and send organization email

61ace38

Empty recipient lists no longer fall through to the whole organization, and send success or failure stays visible in the composer.

Merge origin/main into joel/admin-email-flow

3fec8c2

Keep the admin send rules and the success toast from main.

jlouisugbo deployed to Preview September 24, 2026 19:04 — with GitHub Actions Active

jlouisugbo self-assigned this Sep 24, 2026

jlouisugbo requested a review from shaply September 24, 2026 20:02

greptile-apps Bot reviewed Sep 26, 2026

View reviewed changes

shaply deployed to Preview September 28, 2026 15:55 — with GitHub Actions Active

Merge branch 'main' into joel/admin-email-flow

2ebcbd5

shaply deployed to Preview September 29, 2026 00:59 — with GitHub Actions Active

shaply approved these changes Sep 29, 2026

View reviewed changes

shaply merged commit a25148a into main Sep 29, 2026
25 checks passed

shaply deployed to Preview September 29, 2026 01:17 — with GitHub Actions Active

Navigation Menu

Repository navigation

Complete the admin email sending flow - #285

Complete the admin email sending flow#285
shaply merged 4 commits into
mainfrom
joel/admin-email-flow

jlouisugbo commented Sep 24, 2026 •

edited

Loading

Uh oh!

netlify Bot commented Sep 25, 2026

Uh oh!

netlify Bot commented Sep 25, 2026 •

edited

Loading

Uh oh!

shaply commented Sep 26, 2026

Uh oh!

greptile-apps Bot commented Sep 26, 2026 •

edited

Loading

Uh oh!

greptile-apps Bot Sep 26, 2026

Uh oh!

greptile-apps Bot Sep 26, 2026

Uh oh!

greptile-apps Bot Sep 26, 2026

Uh oh!

shaply commented Sep 28, 2026

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

jlouisugbo commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes Made

Screenshots/Videos

Admin sends successfully

Failed send, draft stays, then retry

Member sees the inbox with no New button

Guest is sent to login

Pending join request is sent away from the inbox

Owner opens the composer

Teammate is listed and a member of another organization is not

QA Steps

Related Tickets

Uh oh!

netlify Bot commented Sep 25, 2026

❌ Deploy Preview for servicestart failed. Why did it fail? →

Uh oh!

netlify Bot commented Sep 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for servicestart ready!

Uh oh!

shaply commented Sep 26, 2026

Uh oh!

greptile-apps Bot commented Sep 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 3/5

Findings

Summary

Uh oh!

greptile-apps Bot Sep 26, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Sep 26, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Sep 26, 2026

Choose a reason for hiding this comment

Uh oh!

shaply commented Sep 28, 2026

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jlouisugbo commented Sep 24, 2026 •

edited

Loading

netlify Bot commented Sep 25, 2026 •

edited

Loading

greptile-apps Bot commented Sep 26, 2026 •

edited

Loading