Skip to content

feat(refactor): Add extraparams parameter to all gameservers - #2120

Closed
borzaka wants to merge 27 commits into
GameServerManagers:developfrom
borzaka:add-extraparams-parameter
Closed

feat(refactor): Add extraparams parameter to all gameservers#2120
borzaka wants to merge 27 commits into
GameServerManagers:developfrom
borzaka:add-extraparams-parameter

Conversation

@borzaka

@borzaka borzaka commented Dec 15, 2018 •
edited by Frisasky
Loading

Copy link
Copy Markdown
Contributor

Description

Now you can easily add any extra parameter to your gameserver without copying and modifying the whole fn_params() in your instance.cfg

Fixes #2183

Type of change

  • Bug fix (non breaking change which fixes an issue)
  • New feature (non breaking change which adds functionality)
  • Refactor (non breaking change restructures existing code)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • This pull request links to an issue
  • I have performed a self review of my own code
  • I have commented my code, particularly in hard to understand areas
  • I have made corresponding changes to the documentation

@borzaka
Add extraparams parameter to all gameservers
9c2ce41 
Now you can easily add any extra parameter to your gameserver without copying and modifying the whole fn_params() in your instance.cfg
@ghost ghost added the Status: dev queue label Dec 15, 2018
@dgibbs64 dgibbs64 closed this Jun 15, 2019
@dgibbs64 dgibbs64 reopened this Jun 15, 2019
@Frisasky

Frisasky commented Jul 11, 2019

Copy link
Copy Markdown
Contributor

i have synced the PR with latest develop codebase, it should be ready for testing

@Frisasky
Frisasky requested a review from dgibbs64 July 11, 2019 00:45
@dgibbs64
dgibbs64 force-pushed the develop branch 2 times, most recently from bfcdc3a to e5402d4 Compare October 29, 2022 11:15
@dgibbs64
dgibbs64 force-pushed the develop branch 5 times, most recently from 891ed8f to ca184e3 Compare September 7, 2023 20:23
@dgibbs64
dgibbs64 force-pushed the develop branch 2 times, most recently from 7a72c04 to f28a4e5 Compare December 3, 2023 00:09
@dgibbs64
dgibbs64 force-pushed the develop branch 2 times, most recently from 8d80501 to fdb8625 Compare April 19, 2026 21:39
@dgibbs64 dgibbs64 closed this Oct 2, 2026
@borzaka borzaka mentioned this pull request Oct 3, 2026
Merged
9 of 17 tasks
@borzaka

borzaka commented Oct 3, 2026

Copy link
Copy Markdown
Contributor Author

Hi @dgibbs64,

I've revived this feature in a new PR: #4970

  • Rebased onto the current develop and squashed into a single commit.
  • extraparams is now added to all 141 game server configs, including servers added since this PR was opened.
  • It's placed consistently: the last entry of the "Predefined Parameters" block, and every startparameters ends with ${extraparams}. The default is empty, so there's no behaviour change unless a user sets it.
  • Fixes Extra Parameters Option #2183. @Frisasky is kept as a co-author for the original work.

borzaka added a commit to borzaka/LinuxGSM that referenced this pull request Oct 5, 2026
@borzaka @Frisasky
feat(config): add extraparams to all game server configs
48f3315 
Add an `extraparams` variable to every game server's _default.cfg so users can append custom start parameters from their instance.cfg without copying and overriding the whole `startparameters` line.

`extraparams=""` is the last entry of the "Predefined Parameters" block in every config, and every `startparameters` ends with `${extraparams}`.

Supersedes GameServerManagers#2120.

Co-authored-by: Frisasky <digimoncn@gmail.com>
borzaka added a commit to borzaka/LinuxGSM that referenced this pull request Oct 10, 2026
@borzaka @Frisasky
feat(config): add extraparams to all game server configs
0e6d46d 
Add an `extraparams` variable to every game server's _default.cfg so users can append custom start parameters from their instance.cfg without copying and overriding the whole `startparameters` line.

`extraparams=""` is the last entry of the "Predefined Parameters" block in every config, and every `startparameters` ends with `${extraparams}`.

Supersedes GameServerManagers#2120.

Co-authored-by: Frisasky <digimoncn@gmail.com>
borzaka added a commit to borzaka/LinuxGSM that referenced this pull request Oct 10, 2026
@borzaka @Frisasky
feat(config): add extraparams to all game server configs
5b75f25 
Add an `extraparams` variable to every game server's _default.cfg so users can append custom start parameters from their instance.cfg without copying and overriding the whole `startparameters` line.

`extraparams=""` is the last entry of the "Predefined Parameters" block in every config, and every `startparameters` ends with `${extraparams}`.

Supersedes GameServerManagers#2120.

Co-authored-by: Frisasky <digimoncn@gmail.com>
borzaka added a commit to borzaka/LinuxGSM that referenced this pull request Oct 11, 2026
@borzaka @Frisasky
feat(config): add extraparams to all game server configs
8dbe659 
Add an `extraparams` variable to every game server's _default.cfg so users can append custom start parameters from their instance.cfg without copying and overriding the whole `startparameters` line.

`extraparams=""` is the last entry of the "Predefined Parameters" block in every config, and every `startparameters` ends with `${extraparams}`.

Supersedes GameServerManagers#2120.

Co-authored-by: Frisasky <digimoncn@gmail.com>
borzaka added a commit to borzaka/LinuxGSM that referenced this pull request Oct 11, 2026
@borzaka @Frisasky
feat(config): add extraparams to all game server configs
57ad717 
Add an `extraparams` variable to every game server's _default.cfg so users can append custom start parameters from their instance.cfg without copying and overriding the whole `startparameters` line.

`extraparams=""` is the last entry of the "Predefined Parameters" block in every config, and every `startparameters` ends with `${extraparams}`.

Supersedes GameServerManagers#2120.

Co-authored-by: Frisasky <digimoncn@gmail.com>
borzaka added a commit to borzaka/LinuxGSM that referenced this pull request Oct 17, 2026
@borzaka @Frisasky @claude
feat(config): add extraparams to all game server configs
67f3055 
Add an `extraparams` variable to every game server's _default.cfg so users can append custom start parameters from their instance.cfg without copying and overriding the whole `startparameters` line.

`extraparams=""` is the last entry of the "Predefined Parameters" block in every config, and every `startparameters` ends with `${extraparams}`.

Supersedes GameServerManagers#2120.

Co-authored-by: Frisasky <digimoncn@gmail.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
borzaka added a commit to borzaka/LinuxGSM that referenced this pull request Oct 18, 2026
@borzaka @Frisasky @claude
feat(config): add extraparams to all game server configs
3c3fcb1 
Add an `extraparams` variable to every game server's _default.cfg so users can append custom start parameters from their instance.cfg without copying and overriding the whole `startparameters` line.

`extraparams=""` is the last entry of the "Predefined Parameters" block in every config, and every `startparameters` ends with `${extraparams}`.

Supersedes GameServerManagers#2120.

Co-authored-by: Frisasky <digimoncn@gmail.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
borzaka added a commit to borzaka/LinuxGSM that referenced this pull request Oct 26, 2026
@borzaka @Frisasky @claude
feat(config): add extraparams to all game server configs
fafffee 
Add an `extraparams` variable to every game server's _default.cfg so users can append custom start parameters from their instance.cfg without copying and overriding the whole `startparameters` line.

`extraparams=""` is the last entry of the "Predefined Parameters" block in every config, and every `startparameters` ends with `${extraparams}`.

Supersedes GameServerManagers#2120.

Co-authored-by: Frisasky <digimoncn@gmail.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dgibbs64 pushed a commit that referenced this pull request Oct 30, 2026
@borzaka @Frisasky
feat(core): add extraparams to append custom start parameters (#4970)
5107135 
Add an extraparams setting that appends custom start parameters to the end
of the start parameters, so users no longer have to copy and override the
whole startparameters line to add a flag.

extraparams is appended once in fn_reload_startparameters, only when set,
so it works for every game server and also when startparameters is
overridden. Every _default.cfg lists extraparams="" in an "Extra
Parameters" entry so users can find it; the startparameters lines are
unchanged.

Fixes #2183
Supersedes #2120

Co-authored-by: borzaka <1230402+borzaka@users.noreply.github.com>
Co-authored-by: Frisasky <digimoncn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgibbs64 dgibbs64 Awaiting requested review from dgibbs64

Assignees

No one assigned

Labels

branch conflicts Branch of pr has conflicts that need to be worked on type: refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@borzaka @Frisasky @dgibbs64 @h3o66