Kerbal EVA death - #181
Open
ondra5555010-cmd wants to merge 2 commits into
Open
Conversation
Updating the function for the EVA death. Beforehand, if the EVA kerbal was your active vessel, he would remain alive until you switched to a different vessel or entered one. Currenlty he dies immidieatly, even when controlled. On the other hand, this does not work on unloaded Kerbals (Kerbals that are far too away from your active vessel). While they will be marked as dead for the purpose of the Kerbal Health, they wont properly die accoring game until players switches to them, or gets near with his active vessel. I do already have an idea how to solve that one, but I will commit that later.
Author
|
Okay, my plan to handle unloaded Kerbals did not work, so this is the best I got |
Fixing of deep cloning for the HealthEffect class. According this testing,this has lead the runaway compounding to dissapear.
Author
|
25.12 |
GarwelGarwel
requested changes
Mar 28, 2026
GarwelGarwel
left a comment
GarwelGarwel
left a comment
Owner
There was a problem hiding this comment.
Sorry, it took me forever to get to this PR. Could you change the target branch to dev? It still has some useful but unapplied changes? Then I'd push them all at once.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating the function for the EVA death. Beforehand, if the EVA kerbal was your active vessel, he would remain alive until you switched to a different vessel or entered one.
Currently he dies immidieatly, even when controlled. On the other hand, this does not work on unloaded Kerbals (Kerbals that are far too away from your active vessel). While they will be marked as dead for the purpose of the Kerbal Health, they wont properly die according to the game until players switches to them, or gets near with his active vessel. I do already have an idea how to solve that one, but I will commit that later.