fix: use extension-only check for deleted/moved file cleanup (#1)

The watcher's on_deleted and on_moved handlers called is_audio_file()
which checks os.path.isfile() - always False for files that no longer
exist on disk. This meant real-time cleanup of output files never
triggered when a source was deleted or renamed.

Add has_audio_extension() that checks only the file extension without
requiring the file to exist, and use it in the watcher handlers for
paths that are no longer on disk.

The periodic sync (every 5 min) already caught orphans as a fallback,
but this fix enables immediate cleanup on deletion events.

Author: GeiserX

pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
 
 [project]
 name = "audio-transcode-watcher"
-version = "0.1.2"
+version = "0.1.3"
 description = "Watch a source folder and automatically transcode audio files to multiple formats"
 readme = "README.md"
 license = "GPL-3.0-or-later"

src/audio_transcode_watcher/utils.py

@@ -38,8 +38,17 @@ def nfc_path(p: str) -> str:
     return normalized
 
 
+def has_audio_extension(path: str) -> bool:
+    """Check if a path has a recognized audio file extension (no existence check).
+
+    Use this instead of is_audio_file() when the file may no longer exist
+    on disk (e.g. in watchdog on_deleted / on_moved handlers).
+    """
+    return Path(nfc_path(path)).suffix.lower() in AUDIO_EXTENSIONS
+
+
 def is_audio_file(path: str) -> bool:
-    """Check if a file is a recognized audio file."""
+    """Check if a file is a recognized audio file (must exist on disk)."""
     normalized = nfc_path(path)
     if not os.path.isfile(normalized):
         return False

src/audio_transcode_watcher/watcher.py

@@ -9,7 +9,7 @@
 
 from .config import Config
 from .sync import delete_outputs, process_source_file, safety_guard_active
-from .utils import is_audio_file
+from .utils import has_audio_extension, is_audio_file
 
 
 class AudioSyncHandler(FileSystemEventHandler):
@@ -59,8 +59,8 @@ def on_moved(self, event) -> None:
         if event.is_directory:
             return
 
-        # Delete outputs for old path
-        if is_audio_file(event.src_path):
+        # Delete outputs for old path (file no longer exists at src_path)
+        if has_audio_extension(event.src_path):
             delete_outputs(event.src_path, self.config)
 
         # Create outputs for new path
@@ -72,7 +72,8 @@ def on_deleted(self, event) -> None:
         if event.is_directory:
             return
 
-        if is_audio_file(event.src_path):
+        # File no longer exists, so check extension only
+        if has_audio_extension(event.src_path):
             delete_outputs(event.src_path, self.config)
 
 

tests/test_utils.py

@@ -7,6 +7,7 @@
 from audio_transcode_watcher.utils import (
     appears_empty_dir,
     get_output_filename,
+    has_audio_extension,
     is_audio_file,
     is_lossless,
     is_mp3,
@@ -61,6 +62,38 @@ def test_handles_empty_path(self):
         assert nfc_path("") == ""
 
 
+class TestHasAudioExtension:
+    """Tests for has_audio_extension function (no file existence check)."""
+    
+    def test_flac_extension(self):
+        """Test that .flac extension is recognized."""
+        assert has_audio_extension("/music/Artist - Song.flac") is True
+    
+    def test_mp3_extension(self):
+        """Test that .mp3 extension is recognized."""
+        assert has_audio_extension("/music/Artist - Song.mp3") is True
+    
+    def test_m4a_extension(self):
+        """Test that .m4a extension is recognized."""
+        assert has_audio_extension("/music/Artist - Song.m4a") is True
+    
+    def test_nonexistent_file_still_recognized(self):
+        """Test that a nonexistent path with audio extension returns True."""
+        assert has_audio_extension("/nonexistent/path/Song.flac") is True
+    
+    def test_txt_extension_not_audio(self):
+        """Test that .txt extension is not recognized."""
+        assert has_audio_extension("/music/readme.txt") is False
+    
+    def test_case_insensitive(self):
+        """Test that extension matching is case-insensitive."""
+        assert has_audio_extension("/music/Song.FLAC") is True
+    
+    def test_no_extension(self):
+        """Test that path without extension is not recognized."""
+        assert has_audio_extension("/music/noext") is False
+
+
 class TestIsAudioFile:
     """Tests for is_audio_file function."""