Merge pull request #135 from GeoscienceAustralia/robbibt-patch-1

Fix sunglint issue in `.io`

Author: erialC-P

intertidal/io.py

@@ -295,7 +295,7 @@ def load_data(
         s2_spectral_bands = s2_spectral_bands + ["nbart_coastal_aerosol"]
 
     # Set sunglint bands to load
-    if mask_sunglint is not None:
+    if (mask_sunglint is not None) and (mask_sunglint >= 1):
         sunglint_bands = [
             "oa_solar_zenith",
             "oa_solar_azimuth",

tests/README.md

@@ -10,7 +10,7 @@ Integration tests
 
 This directory contains tests that are run to verify that DEA Intertidal code runs correctly. The ``test_intertidal.py`` file runs a small-scale full workflow analysis over an intertidal flat in the Gulf of Carpentaria using the DEA Intertidal [Command Line Interface (CLI) tools](../notebooks/Intertidal_CLI.ipynb), and compares these results against a LiDAR validation DEM to produce some simple accuracy metrics.
 
-The latest integration test completed at **2025-07-31 13:15**. Compared to the previous run, it had an:
+The latest integration test completed at **2025-07-31 14:04**. Compared to the previous run, it had an:
 - RMSE accuracy of **0.14 m ( :heavy_minus_sign: no change)**
 - MAE accuracy of **0.12 m ( :heavy_minus_sign: no change)**
 - Bias of **0.12 m ( :heavy_minus_sign: no change)**

tests/validation.csv

@@ -125,3 +125,4 @@ time,Correlation,RMSE,MAE,R-squared,Bias,Regression slope
 2025-07-16 06:35:53.694461+00:00,0.975,0.145,0.123,0.95,0.117,1.119
 2025-07-16 07:07:43.740627+00:00,0.975,0.145,0.123,0.95,0.117,1.119
 2025-07-31 03:15:11.418435+00:00,0.975,0.145,0.123,0.95,0.117,1.119
+2025-07-31 04:04:50.918639+00:00,0.975,0.145,0.123,0.95,0.117,1.119