Repository navigation
simple-markdown is not listed as a dependency/peer dependency #1787
Description
Describe the bug
Peer dependency for simple-markdown not specified in any package.json.
Dev environment info (please complete/provide the following information):
- Package version - v5.2.0
- react-native
- Device/Emulator (android/ios) and OS version - BOTH
To Reproduce
Run a dev build or standard build
Expected behavior
You should list it as a peer dependency so we know to install it and what version
Screenshots
Activity
madsroskar commentedon Nov 8, 2022
simple-markdownis a dependency ofreact-native-markdown-package, which in turn is a dependency ofstream-chat-react-native-core, and should be available through your package manager when that is resolved. Are you able to make a minimal reproduction of this issue? When I set up a simple app using the SDK, I'm not able to reproduce an issue ofsimple-markdownnot being available.joelpierre commentedon Nov 8, 2022
Yeah I noticed that too. So was surprised it wasn't "auto" resolved. We are however using a mono repo with yarn workspaces with an installConfig.hoistingLimit set to
dependencies. Theoretically it should install all of your modules packages regardless of this setting however it is missing.Our fix for now is just to add that as a dependency for us. However with that being said, if you use the package directly in your core package I think you should reference it in your package.json?
I can't get to minimal reproduction for now 😅
[-]`simple-markdown` is not listed as a peer dependency[/-][+]`simple-markdown` is not listed as a dependency/peer dependency[/+]vishalnarkhede commentedon Nov 14, 2022
@joelpierre Since it's not a blocker for you are the moment, I am going to move it to a discussion for anyone to add more suggestions to this problem.