11import type { ComponentProps , ComponentType } from 'react' ;
2- import React , { useEffect , useRef } from 'react' ;
2+ import React , { useEffect , useMemo , useRef } from 'react' ;
33import type { Channel , ChannelPaginator , ChannelPaginatorState } from 'stream-chat' ;
44
55import { ChannelListItem } from '../ChannelListItem' ;
@@ -48,16 +48,20 @@ export type ChannelListProps = {
4848 loadMoreThresholdPx ?: number ;
4949} ;
5050
51- const channelPaginatorStateSelector = ( state : ChannelPaginatorState ) => ( {
52- // `items === undefined` means "never queried": the initial state, and where a paginator returns
53- // when its data is discarded (e.g. `client.disconnectUser` resets every registered list). An
54- // empty array is a loaded empty page and must not trigger a query. A failed first page leaves
55- // `items` undefined too, but holds the error until a retry or a reset; with `throwErrors` set,
56- // that error is all that keeps the list from querying again and again.
57- awaitsFirstPage : state . items === undefined && ! state . isLoading && ! state . lastQueryError ,
58- firstPageLoadError : getFirstPageLoadError ( state ) ,
59- lastQueryError : state . lastQueryError ,
60- } ) ;
51+ const createChannelPaginatorStateSelector =
52+ ( paginator : ChannelPaginator ) => ( state : ChannelPaginatorState ) => ( {
53+ // No loaded page: the initial state, and where a paginator returns when its data is discarded
54+ // (e.g. `client.disconnectUser` resets every registered list). Not `items === undefined`: a
55+ // live event can route a channel into a list that was never queried, which defines `items`
56+ // without loading a page. A loaded empty page (also one set with `setItems`, e.g. a catch-all
57+ // list seeded so it never queries) must not trigger a query. A failed first page loads none
58+ // either, but holds the error until a retry or a reset; with `throwErrors` set, that error is
59+ // all that keeps the list from querying again and again.
60+ awaitsFirstPage :
61+ ! paginator . hasLoadedPage && ! state . isLoading && ! state . lastQueryError ,
62+ firstPageLoadError : getFirstPageLoadError ( state ) ,
63+ lastQueryError : state . lastQueryError ,
64+ } ) ;
6165
6266/**
6367 * Channel list driven by a single `ChannelPaginator`: it renders the paginator's state and drives
@@ -72,6 +76,10 @@ export const ChannelList = ({
7276} : ChannelListProps ) => {
7377 const { channelManager } = useChatContext ( ) ;
7478 const { t } = useTranslationContext ( ) ;
79+ const channelPaginatorStateSelector = useMemo (
80+ ( ) => createChannelPaginatorStateSelector ( paginator ) ,
81+ [ paginator ] ,
82+ ) ;
7583 const { awaitsFirstPage, firstPageLoadError, lastQueryError } = useStateStore (
7684 paginator . state ,
7785 channelPaginatorStateSelector ,
@@ -95,12 +103,12 @@ export const ChannelList = ({
95103 // Ref-counted, so `Chat` and other lists can register the same subscriptions.
96104 useEffect ( ( ) => channelManager . registerSubscriptions ( ) , [ channelManager ] ) ;
97105
98- // Loads the first page, and again whenever the list returns to "never queried ": the paginator
106+ // Loads the first page, and again whenever the list returns to "no page loaded ": the paginator
99107 // outlives this component, so querying only on mount would leave a reset list permanently empty.
100- // An initialized paginator has queried already; its pages arrive through that query or its
101- // recovery, and a query from here would load the next page.
108+ // A paginator with a loaded page has queried already (or was seeded) ; its pages arrive through
109+ // that query or its recovery, and a query from here would load the next page.
102110 useEffect ( ( ) => {
103- if ( ! awaitsFirstPage || paginator . isInitialized ) return ;
111+ if ( ! awaitsFirstPage ) return ;
104112 paginator . toTailDebounced ( ) ;
105113 } , [ awaitsFirstPage , paginator ] ) ;
106114
0 commit comments