Repository navigation
docs(ai-migration): open the first channel once per load, not after every close #3358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
50b6c9f
feat: add useOpenFirstChannel and createWorkspaceNavigation
oliverlaz 192baeb
refactor: replace useOpenFirstChannel with a guide snippet
oliverlaz af1318d
Merge remote-tracking branch 'origin/master' into feat/workspace-navi…
oliverlaz a2e8b10
refactor: drop createWorkspaceNavigation, keep the guide fix only
oliverlaz c6c84c9
docs(ai-migration): note the sign-out and several-lists caveats of us…
oliverlaz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script executed:
Repository: GetStream/stream-chat-react
Length of output: 30997
Script executed:
Repository: GetStream/stream-chat-react
Length of output: 7479
Persist the handled-load state across remounts.
awaitingLoadresets totruewhenever this effect remounts. BecausesubscribeWithSelectorinvokes its callback immediately with the current value, a loaded paginator with no open channel can callopenChannel(first)again after a remount. This can reopen the first channel after the user closes it.Persist the handled-load state across remounts, while preserving the reset when
items === undefined. Add a remount test with a loaded paginator and no open channel.