chore(core): stop sending legacy raw stats in SendStats (#1861)

Syncs signal.proto with GetStream/protocol#2116, which removed the deprecated
SendStatsRequest fields. Android only populated publisher_stats and
subscriber_stats; sendCallStats() no longer takes a CallStatsReport and the
collectStats() calls that only existed to fill it are gone.

Co-authored-by: Pratim Mallick <34009202+PratimMallick@users.noreply.github.com>

Author: aleksandar-apostolov

stream-video-android-core/api/stream-video-android-core.api

@@ -19019,28 +19019,22 @@ public final class stream/video/sfu/signal/SendStatsRequest : com/squareup/wire/
 	public static final field ADAPTER Lcom/squareup/wire/ProtoAdapter;
 	public static final field Companion Lstream/video/sfu/signal/SendStatsRequest$Companion;
 	public fun <init> ()V
-	public fun <init> (Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Lstream/video/sfu/models/InputDevices;Lstream/video/sfu/models/InputDevices;Lstream/video/sfu/models/AndroidState;Lstream/video/sfu/models/AppleState;Lstream/video/sfu/signal/Telemetry;Lstream/video/sfu/models/RTMPIngress;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/util/List;Ljava/util/List;Ljava/lang/String;Lokio/ByteString;)V
-	public synthetic fun <init> (Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Lstream/video/sfu/models/InputDevices;Lstream/video/sfu/models/InputDevices;Lstream/video/sfu/models/AndroidState;Lstream/video/sfu/models/AppleState;Lstream/video/sfu/signal/Telemetry;Lstream/video/sfu/models/RTMPIngress;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/util/List;Ljava/util/List;Ljava/lang/String;Lokio/ByteString;ILkotlin/jvm/internal/DefaultConstructorMarker;)V
-	public final fun copy (Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Lstream/video/sfu/models/InputDevices;Lstream/video/sfu/models/InputDevices;Lstream/video/sfu/models/AndroidState;Lstream/video/sfu/models/AppleState;Lstream/video/sfu/signal/Telemetry;Lstream/video/sfu/models/RTMPIngress;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/util/List;Ljava/util/List;Ljava/lang/String;Lokio/ByteString;)Lstream/video/sfu/signal/SendStatsRequest;
-	public static synthetic fun copy$default (Lstream/video/sfu/signal/SendStatsRequest;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Lstream/video/sfu/models/InputDevices;Lstream/video/sfu/models/InputDevices;Lstream/video/sfu/models/AndroidState;Lstream/video/sfu/models/AppleState;Lstream/video/sfu/signal/Telemetry;Lstream/video/sfu/models/RTMPIngress;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/util/List;Ljava/util/List;Ljava/lang/String;Lokio/ByteString;ILjava/lang/Object;)Lstream/video/sfu/signal/SendStatsRequest;
+	public fun <init> (Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Lstream/video/sfu/models/AndroidState;Lstream/video/sfu/models/AppleState;Lstream/video/sfu/signal/Telemetry;Lstream/video/sfu/models/RTMPIngress;Ljava/lang/String;Ljava/util/List;Ljava/util/List;Ljava/lang/String;Lokio/ByteString;)V
+	public synthetic fun <init> (Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Lstream/video/sfu/models/AndroidState;Lstream/video/sfu/models/AppleState;Lstream/video/sfu/signal/Telemetry;Lstream/video/sfu/models/RTMPIngress;Ljava/lang/String;Ljava/util/List;Ljava/util/List;Ljava/lang/String;Lokio/ByteString;ILkotlin/jvm/internal/DefaultConstructorMarker;)V
+	public final fun copy (Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Lstream/video/sfu/models/AndroidState;Lstream/video/sfu/models/AppleState;Lstream/video/sfu/signal/Telemetry;Lstream/video/sfu/models/RTMPIngress;Ljava/lang/String;Ljava/util/List;Ljava/util/List;Ljava/lang/String;Lokio/ByteString;)Lstream/video/sfu/signal/SendStatsRequest;
+	public static synthetic fun copy$default (Lstream/video/sfu/signal/SendStatsRequest;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Lstream/video/sfu/models/AndroidState;Lstream/video/sfu/models/AppleState;Lstream/video/sfu/signal/Telemetry;Lstream/video/sfu/models/RTMPIngress;Ljava/lang/String;Ljava/util/List;Ljava/util/List;Ljava/lang/String;Lokio/ByteString;ILjava/lang/Object;)Lstream/video/sfu/signal/SendStatsRequest;
 	public fun equals (Ljava/lang/Object;)Z
 	public final fun getAndroid ()Lstream/video/sfu/models/AndroidState;
 	public final fun getApple ()Lstream/video/sfu/models/AppleState;
-	public final fun getAudio_devices ()Lstream/video/sfu/models/InputDevices;
 	public final fun getDecode_stats ()Ljava/util/List;
 	public final fun getEncode_stats ()Ljava/util/List;
-	public final fun getPublisher_rtc_stats ()Ljava/lang/String;
-	public final fun getPublisher_stats ()Ljava/lang/String;
 	public final fun getRtc_stats ()Ljava/lang/String;
 	public final fun getRtmp ()Lstream/video/sfu/models/RTMPIngress;
 	public final fun getSdk ()Ljava/lang/String;
 	public final fun getSdk_version ()Ljava/lang/String;
 	public final fun getSession_id ()Ljava/lang/String;
-	public final fun getSubscriber_rtc_stats ()Ljava/lang/String;
-	public final fun getSubscriber_stats ()Ljava/lang/String;
 	public final fun getTelemetry ()Lstream/video/sfu/signal/Telemetry;
 	public final fun getUnified_session_id ()Ljava/lang/String;
-	public final fun getVideo_devices ()Lstream/video/sfu/models/InputDevices;
 	public final fun getWebrtc_version ()Ljava/lang/String;
 	public fun hashCode ()I
 	public synthetic fun newBuilder ()Lcom/squareup/wire/Message$Builder;

stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/Call.kt

@@ -423,7 +423,6 @@ public class Call(
         apiClient = apiClient,
         state = state,
         callAnalytics = callAnalytics,
-        statsReporter = statsReporter,
         sessionMonitor = { sessionMonitor },
         type = type,
         id = id,
@@ -734,8 +733,6 @@ public class Call(
 
     // endregion
 
-    internal suspend fun collectStats(): CallStatsReport = statsReporter.collectStats()
-
     // region Reconnection — unified loop
 
     /**

stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/CallStatsReport.kt

@@ -33,6 +33,10 @@ data class CallStatsReport(
     val stateStats: CallStats,
 )
 
+@Deprecated(
+    "The raw per-peer stats this serializes are no longer part of the SendStats payload. " +
+        "Nothing in the SDK calls it; it will be removed in the next major version.",
+)
 fun CallStatsReport.toJson(peerType: StreamPeerType): String {
     val stats: Map<String, RTCStats>? = if (peerType == StreamPeerType.PUBLISHER) {
         publisher?.origin?.statsMap

stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/call/RtcSession.kt

@@ -40,7 +40,6 @@ import io.getstream.result.Result.Failure
 import io.getstream.result.Result.Success
 import io.getstream.video.android.core.BuildConfig
 import io.getstream.video.android.core.Call
-import io.getstream.video.android.core.CallStatsReport
 import io.getstream.video.android.core.DeviceStatus
 import io.getstream.video.android.core.MediaManagerImpl
 import io.getstream.video.android.core.RealtimeConnection
@@ -1179,12 +1178,10 @@ public class RtcSession internal constructor(
     private suspend fun sendConnectionTimeStats(reconnectStrategy: WebsocketReconnectStrategy? = null) {
         if (reconnectStrategy == null) {
             sendCallStats(
-                report = call.collectStats(),
                 connectionTimeSeconds = sessionManager.connectionTimeSeconds(),
             )
         } else {
             sendCallStats(
-                report = call.collectStats(),
                 reconnectionTimeSeconds = Pair(
                     sessionManager.reconnectionTimeSeconds(),
                     reconnectStrategy,
@@ -2000,7 +1997,6 @@ public class RtcSession internal constructor(
     }
 
     internal suspend fun sendCallStats(
-        report: CallStatsReport? = null,
         connectionTimeSeconds: Float? = null,
         reconnectionTimeSeconds: Pair<Float, WebsocketReconnectStrategy>? = null,
     ) {
@@ -2051,8 +2047,6 @@ public class RtcSession internal constructor(
                 unified_session_id = sessionManager.unifiedSessionId,
                 sdk_version = BuildConfig.STREAM_VIDEO_VERSION,
                 webrtc_version = BuildConfig.STREAM_WEBRTC_VERSION,
-                publisher_stats = report?.toJson(StreamPeerType.PUBLISHER) ?: "",
-                subscriber_stats = report?.toJson(StreamPeerType.SUBSCRIBER) ?: "",
                 rtc_stats = rtcStats,
 
                 encode_stats = publisherRtcStats?.performanceStats ?: emptyList(),
@@ -2266,8 +2260,7 @@ public class RtcSession internal constructor(
     }
 
     internal suspend fun prepareRejoin(reason: String) {
-        val stats = call.collectStats()
-        sendCallStats(stats)
+        sendCallStats()
 
         // Mark disconnected immediately — late ICE candidates will be routed
         // to iceTricklePendingEvents instead of being sent to the now-defunct SFU.

stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/call/components/CallLifecycleManager.kt

@@ -114,8 +114,7 @@ internal class CallLifecycleManager(
             callAnalytics.onCallLeave(sessionManager.session, reason)
             safeCall {
                 sessionManager.session.value?.sfuTracer?.trace("leave-call", leaveReason)
-                val stats = statsReporter.collectStats()
-                sessionManager.session.value?.sendCallStats(stats)
+                sessionManager.session.value?.sendCallStats()
             }
             // Must complete before cleanup() cancels the session's supervisor job.
             safeCall { sessionManager.session.value?.sendLeaveEvent(leaveReason) }

stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/call/components/CallReconnector.kt

@@ -75,7 +75,6 @@ internal class CallReconnector(
     private val apiClient: CallApiClient,
     private val state: CallState,
     private val callAnalytics: CallAnalytics,
-    private val statsReporter: CallStatsReporter,
     // Lazy provider: the session monitor is built from the connectivity monitor, which takes
     // this component, so it can only be resolved after construction.
     private val sessionMonitor: () -> SessionMonitor,
@@ -331,8 +330,7 @@ internal class CallReconnector(
         val currentSession = sessionManager.session.value
             ?: return ReconnectOutcome.PreconditionNotMet("No active session for fast reconnect")
 
-        val stats = statsReporter.collectStats()
-        currentSession.sendCallStats(stats)
+        currentSession.sendCallStats()
 
         currentSession.prepareReconnect()
         state._connection.value = RealtimeConnection.Reconnecting
@@ -466,8 +464,7 @@ internal class CallReconnector(
             reconnect_attempt = sessionManager.nonFastReconnectAttempts,
         )
 
-        val stats = statsReporter.collectStats()
-        oldSession.sendCallStats(stats)
+        oldSession.sendCallStats()
         oldSession.enterMigration()
 
         val newSession = sessionFactory.create(

stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/call/components/CallStatsReporter.kt

@@ -55,9 +55,10 @@ internal class CallStatsReporter(
 
             while (isActive) {
                 delay(reportingIntervalMs)
-                sessionManager.session.value?.sendCallStats(
-                    report = collectStats(),
-                )
+                // Still collected on every tick: it refreshes [statsReport],
+                // [statLatencyHistory] and [state.stats] for local observers.
+                collectStats()
+                sessionManager.session.value?.sendCallStats()
             }
         }
     }

stream-video-android-core/src/main/proto/video/sfu/signal_rpc/signal.proto

@@ -79,23 +79,18 @@ message SendMetricsResponse {
 
 message SendStatsRequest {
   string session_id = 1;
-  string subscriber_stats = 2;
-  string publisher_stats = 3;
+  reserved 2, 3, 7, 8, 13, 14;
   string webrtc_version = 4;
   string sdk = 5;
   string sdk_version = 6;
 
-  models.InputDevices audio_devices = 7;
-  models.InputDevices video_devices = 8;
   oneof device_state {
     models.AndroidState android = 9;
     models.AppleState apple = 10;
   }
 
   Telemetry telemetry = 11;
   models.RTMPIngress rtmp = 12;
-  string subscriber_rtc_stats = 13 [deprecated = true];
-  string publisher_rtc_stats = 14 [deprecated = true];
   string rtc_stats = 15;
   // Encode stats for the publisher
   repeated models.PerformanceStats encode_stats = 16;

stream-video-android-core/src/test/kotlin/io/getstream/video/android/core/call/components/CallReconnectorTest.kt

@@ -55,7 +55,6 @@ class CallReconnectorTest {
     private lateinit var sessionManager: CallSessionManager
     private lateinit var sessionMonitor: SessionMonitor
     private lateinit var lifecycle: CallLifecycleManager
-    private lateinit var statsReporter: CallStatsReporter
     private lateinit var apiClient: CallApiClient
     private lateinit var callAnalytics: CallAnalytics
     private lateinit var sessionFactory: RtcSessionFactory
@@ -67,7 +66,6 @@ class CallReconnectorTest {
         connectionFlow = MutableStateFlow(RealtimeConnection.Reconnecting)
         sessionMonitor = mockk(relaxed = true)
         lifecycle = mockk(relaxed = true)
-        statsReporter = mockk(relaxed = true)
         apiClient = mockk(relaxed = true)
         callAnalytics = mockk(relaxed = true)
         sessionFactory = mockk(relaxed = true)
@@ -94,7 +92,6 @@ class CallReconnectorTest {
         apiClient = apiClient,
         state = state,
         callAnalytics = callAnalytics,
-        statsReporter = statsReporter,
         sessionMonitor = { sessionMonitor },
         type = "default",
         id = "call-id",

stream-video-android-core/src/test/kotlin/io/getstream/video/android/core/rtc/RtcSessionTest2.kt

@@ -248,7 +248,7 @@ class RtcSessionTest2 {
                     sfuAnalytics = SfuAnalytics.getFakeSfuAnalytics(),
                 ),
             )
-            coJustRun { rtcSession.sendCallStats(any(), any(), any()) }
+            coJustRun { rtcSession.sendCallStats(any(), any()) }
 
             // When
             rtcSession.connect()
@@ -308,7 +308,7 @@ class RtcSessionTest2 {
                     sfuAnalytics = SfuAnalytics.getFakeSfuAnalytics(),
                 ),
             )
-            coJustRun { rtcSession.sendCallStats(any(), any(), any()) }
+            coJustRun { rtcSession.sendCallStats(any(), any()) }
 
             val result = rtcSession.connectInternal()
 
@@ -368,7 +368,7 @@ class RtcSessionTest2 {
                     sfuAnalytics = SfuAnalytics.getFakeSfuAnalytics(),
                 ),
             )
-            coJustRun { rtcSession.sendCallStats(any(), any(), any()) }
+            coJustRun { rtcSession.sendCallStats(any(), any()) }
 
             val resultDeferred = async { rtcSession.connectInternal() }
             // Socket state observation timeout = 2 * 50ms + 1000ms grace
@@ -440,7 +440,7 @@ class RtcSessionTest2 {
                     sfuAnalytics = SfuAnalytics.getFakeSfuAnalytics(),
                 ),
             )
-            coJustRun { rtcSession.sendCallStats(any(), any(), any()) }
+            coJustRun { rtcSession.sendCallStats(any(), any()) }
 
             val result = rtcSession.connectInternal()
 
@@ -499,7 +499,7 @@ class RtcSessionTest2 {
                     sfuAnalytics = SfuAnalytics.getFakeSfuAnalytics(),
                 ),
             )
-            coJustRun { rtcSession.sendCallStats(any(), any(), any()) }
+            coJustRun { rtcSession.sendCallStats(any(), any()) }
 
             val result = rtcSession.connectInternal()
 
@@ -548,7 +548,7 @@ class RtcSessionTest2 {
                     sfuAnalytics = SfuAnalytics.getFakeSfuAnalytics(),
                 ),
             )
-            coJustRun { rtcSession.sendCallStats(any(), any(), any()) }
+            coJustRun { rtcSession.sendCallStats(any(), any()) }
 
             val reconnectDetails = ReconnectDetails(
                 strategy = WebsocketReconnectStrategy.WEBSOCKET_RECONNECT_STRATEGY_REJOIN,