Repository navigation
Fetch ringing tutorial credentials from the demo token generator - #1890
Closed
aleksandar-apostolov wants to merge 1 commit into
Closed
aleksandar-apostolov wants to merge 1 commit into
aleksandar-apostolov wants to merge 1 commit into
Conversation
…erator The API key hardcoded in the ringing tutorial was revoked, and the bundled user tokens were signed with its secret. Fetch the API key and token from the demo token generator at login instead, so the tutorial no longer hardcodes keys.
Contributor
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
Contributor
SDK Size Comparison 📏
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Fixes AND-1708 — the ringing tutorial hardcoded a revoked API key and tokens signed with its secret, so it could no longer log in.
Implementation
RingingApp.loginis nowsuspendand fetchesapiKey+tokenfrompronto.getstream.io/api/auth/create-token?environment=demobefore buildingStreamVideo.TutorialUser.MainActivitylogs in fromlifecycleScope; on a network or parse failure it logs and stays on the login screen.Testing
./gradlew :tutorials:tutorial-ringing:assembleDebug