Repository navigation
Conversation
DefaultRedirectsService.DeleteById removed the row but, unlike every other write on the service, never raised RedirectsEvents.RedirectsUpdated. The admin redirects list's Delete button calls it, so CustomRedirectHandler kept serving the deleted redirect until the application restarted or another redirect was saved, and OptimizelySyncEvents never relayed the change to other instances. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #194.
DefaultRedirectsService.DeleteByIdremoved the redirect from the database but, unlike every other write on the service, never raisedRedirectsEvents.RedirectsUpdated. The redirects list's Delete button calls it, soCustomRedirectHandlerwent on serving the deleted redirect until the application restarted or another redirect was added or changed, andOptimizelySyncEventsnever relayed the delete to other instances.Change
DeleteByIdraisesRedirectsUpdatedafter the delete. LikeDeleteByOldUrl, it raises it whether or not a row matched.[Unreleased]. Renumber it to suit the release.Tests
DefaultRedirectsServiceTests, the first tests for this service:DeleteById_raises_redirects_updatedcovers the event thatOptimizelySyncEventsrelays to other instances.DeleteById_removes_redirect_from_redirect_handlerruns the realRedirectsInitializerandCustomRedirectHandler, and checks that the deleted redirect is no longer found.Geta.NotFoundHandler.Testspasses 62/62 on net10.0.The same change for CMS 12 is in #196, against
release/v6.🤖 Generated with Claude Code