memory saves + new status anim

Author: jaylikesbunda

src/main.c

@@ -75,9 +75,9 @@ int32_t ghost_esp_app(void* p) {
     state->came_from_settings = false;
 
     // Initialize essential text buffers with minimal size
-    state->textBoxBuffer = malloc(1);
+    state->textBoxBuffer = malloc(TEXT_BOX_STORE_SIZE);
     if(state->textBoxBuffer) {
-        state->textBoxBuffer[0] = '\0';
+        memset(state->textBoxBuffer, 0, TEXT_BOX_STORE_SIZE);
     }
     state->buffer_length = 0;
     state->input_buffer = malloc(INPUT_BUFFER_SIZE);

src/menu.c

@@ -905,6 +905,13 @@ static const MenuCommand status_idle_commands[] = {
         .details_text = "Set idle status display to\n"
                         "HUD-style overlay.",
     },
+    {
+        .label = "Matrix",
+        .command = "statusidle set matrix\n",
+        .details_header = "Matrix Animation",
+        .details_text = "Set idle status display to\n"
+                        "Matrix-style rain effect.",
+    },
 };
 
 // BLE menu command definitions
@@ -1203,15 +1210,15 @@ static bool ir_query_and_parse_list(AppState* state) {
     uart_reset_text_buffers(state->uart_context);
     send_uart_command("ir list\n", state);
 
-    char* buffer = malloc(IR_UART_PARSE_BUF_SIZE);
-    if(!buffer) return false;
+    char buffer[IR_UART_PARSE_BUF_SIZE];
 
     size_t len = 0;
     uint32_t start = furi_get_tick();
     const uint32_t timeout_ms = 2000;
     while(furi_get_tick() - start < timeout_ms) {
         furi_delay_ms(100);
-        if(uart_copy_text_buffer(state->uart_context, buffer, IR_UART_PARSE_BUF_SIZE, &len) &&
+        if(uart_copy_text_buffer_tail(
+               state->uart_context, buffer, IR_UART_PARSE_BUF_SIZE, &len) &&
            len > 0) {
             if(strstr(buffer, "IR files in ") || strstr(buffer, "(none)") ||
                strstr(buffer, "(none).") || strchr(buffer, '[')) {
@@ -1221,7 +1228,6 @@ static bool ir_query_and_parse_list(AppState* state) {
     }
 
     if(len == 0) {
-        free(buffer);
         return false;
     }
 
@@ -1252,7 +1258,6 @@ static bool ir_query_and_parse_list(AppState* state) {
         }
     }
 
-    free(buffer);
     return state->ir_remote_count > 0;
 }
 
@@ -1265,15 +1270,15 @@ static bool ir_query_and_parse_show(AppState* state, uint32_t remote_index) {
     snprintf(cmd, sizeof(cmd), "ir show %lu\n", (unsigned long)remote_index);
     send_uart_command(cmd, state);
 
-    char* buffer = malloc(IR_UART_PARSE_BUF_SIZE);
-    if(!buffer) return false;
+    char buffer[IR_UART_PARSE_BUF_SIZE];
 
     size_t len = 0;
     uint32_t start = furi_get_tick();
     const uint32_t timeout_ms = 3000;
     while(furi_get_tick() - start < timeout_ms) {
         furi_delay_ms(100);
-        if(uart_copy_text_buffer(state->uart_context, buffer, IR_UART_PARSE_BUF_SIZE, &len) &&
+        if(uart_copy_text_buffer_tail(
+               state->uart_context, buffer, IR_UART_PARSE_BUF_SIZE, &len) &&
            len > 0) {
             if(strstr(buffer, "Signals in ") || strstr(buffer, "Unique buttons in ") ||
                strchr(buffer, '[')) {
@@ -1283,7 +1288,6 @@ static bool ir_query_and_parse_show(AppState* state, uint32_t remote_index) {
     }
 
     if(len == 0) {
-        free(buffer);
         return false;
     }
 
@@ -1322,7 +1326,6 @@ static bool ir_query_and_parse_show(AppState* state, uint32_t remote_index) {
         }
     }
 
-    free(buffer);
     return state->ir_signal_count > 0;
 }
 
@@ -1333,14 +1336,12 @@ static bool ir_query_and_parse_universals(AppState* state) {
     send_uart_command("ir universals list\n", state);
     furi_delay_ms(200);
 
-    char* buffer = malloc(IR_UART_PARSE_BUF_SIZE);
-    if(!buffer) return false;
+    char buffer[IR_UART_PARSE_BUF_SIZE];
 
     size_t len = 0;
-    if(!uart_copy_text_buffer(
+    if(!uart_copy_text_buffer_tail(
            state->uart_context, buffer, IR_UART_PARSE_BUF_SIZE, &len) ||
        len == 0) {
-        free(buffer);
         return false;
     }
 
@@ -1390,7 +1391,6 @@ static bool ir_query_and_parse_universals(AppState* state) {
         }
     }
 
-    free(buffer);
     return state->ir_universal_count > 0;
 }
 
@@ -1406,8 +1406,7 @@ static bool ir_query_and_parse_universal_buttons(AppState* state, const char* fi
     snprintf(cmd, sizeof(cmd), "ir show %s\n", path);
     send_uart_command(cmd, state);
 
-    char* buffer = malloc(IR_UART_PARSE_BUF_SIZE);
-    if(!buffer) return false;
+    char buffer[IR_UART_PARSE_BUF_SIZE];
 
     size_t len = 0;
 
@@ -1424,7 +1423,6 @@ static bool ir_query_and_parse_universal_buttons(AppState* state, const char* fi
     }
 
     if(len == 0) {
-        free(buffer);
         return false;
     }
 
@@ -1477,7 +1475,6 @@ static bool ir_query_and_parse_universal_buttons(AppState* state, const char* fi
     }
 
     bool result = state->ir_signal_count > 0;
-    free(buffer);
     return result;
 }
 
@@ -1819,8 +1816,8 @@ static bool handle_ir_command_feedback_ex(
 
     if(is_uni_sendall) {
         state->previous_view = state->current_view;
-        confirmation_view_set_header(state->confirmation_view, "IR Sweep");
-        confirmation_view_set_text(state->confirmation_view, "Transmitting sweep...\nOK = Stop");
+        confirmation_view_set_header(state->confirmation_view, "Universal send");
+        confirmation_view_set_text(state->confirmation_view, "Universal sending...\nOK = Stop");
         confirmation_view_set_ok_callback(state->confirmation_view, ir_sweep_stop_callback, state);
         confirmation_view_set_cancel_callback(
             state->confirmation_view, app_info_ok_callback, state);
@@ -1842,7 +1839,7 @@ static bool handle_ir_command_feedback_ex(
     bool saw_ok = false;
 
     uint32_t start = furi_get_tick();
-    const uint32_t timeout_ms = 5000;
+    const uint32_t timeout_ms = is_uni_sendall ? 60000 : 5000;
 
     while(furi_get_tick() - start < timeout_ms) {
         furi_delay_ms(100);
@@ -1873,7 +1870,8 @@ static bool handle_ir_command_feedback_ex(
                     char freq_str[24] = {0};
                     char duty_str[16] = {0};
 
-                    if(strstr(p, " raw ") || strstr(p, " raw len=")) {
+                    if(strncmp(p, "raw ", 4) == 0 || strncmp(p, "raw len=", 8) == 0 ||
+                       strstr(p, " raw ") || strstr(p, " raw len=")) {
                         if(sscanf(
                                line,
                                "IR: signal raw len=%15s freq=%31s duty=%15s",
@@ -1995,20 +1993,13 @@ static bool handle_ir_command_feedback_ex(
                 if(strstr(line, "universal sendall already running")) {
                     strncpy(
                         message,
-                        "Universal sweep already running; use 'stop' to cancel.",
+                        "Universal send already running; use 'stop' to cancel.",
                         sizeof(message) - 1);
                     message[sizeof(message) - 1] = '\0';
                     start = timeout_ms + start;
                     break;
                 }
                 if(strstr(line, "universal sendall started")) {
-                    strncpy(
-                        message,
-                        "Universal sending\nPress OK to stop and exit",
-                        sizeof(message) - 1);
-                    message[sizeof(message) - 1] = '\0';
-                    start = timeout_ms + start;
-                    break;
                 }
                 if(strstr(line, "no builtin signals named")) {
                     strncpy(message, "No builtin signals with that name.", sizeof(message) - 1);
@@ -2023,14 +2014,26 @@ static bool handle_ir_command_feedback_ex(
                     break;
                 }
                 if(strstr(line, "universal sendall finished")) {
-                    strncpy(message, "Universal sweep finished.", sizeof(message) - 1);
+                    strncpy(message, "Universal send finished.", sizeof(message) - 1);
                     message[sizeof(message) - 1] = '\0';
+                    confirmation_view_set_header(state->confirmation_view, "Universal send");
+                    confirmation_view_set_text(state->confirmation_view, message);
+                    confirmation_view_set_ok_callback(
+                        state->confirmation_view, app_info_ok_callback, state);
+                    confirmation_view_set_cancel_callback(
+                        state->confirmation_view, app_info_ok_callback, state);
                     start = timeout_ms + start;
                     break;
                 }
                 if(strstr(line, "universal sendall stopped")) {
-                    strncpy(message, "Universal sweep stopped.", sizeof(message) - 1);
+                    strncpy(message, "Universal send stopped.", sizeof(message) - 1);
                     message[sizeof(message) - 1] = '\0';
+                    confirmation_view_set_header(state->confirmation_view, "Universal send");
+                    confirmation_view_set_text(state->confirmation_view, message);
+                    confirmation_view_set_ok_callback(
+                        state->confirmation_view, app_info_ok_callback, state);
+                    confirmation_view_set_cancel_callback(
+                        state->confirmation_view, app_info_ok_callback, state);
                     start = timeout_ms + start;
                     break;
                 }
@@ -2103,11 +2106,22 @@ static void text_input_result_callback(void* context) {
         input_state->connect_input_stage = 0;
         input_state->connect_ssid[0] = '\0';
     } else {
-        send_uart_command_with_text(
-            input_state->uart_command, input_state->input_buffer, input_state);
+        if(input_state->uart_command && strcmp(input_state->uart_command, "ir send") == 0) {
+            char cmd[256];
+            snprintf(cmd, sizeof(cmd), "ir send %s\n", input_state->input_buffer);
+            handle_ir_command_feedback_ex(input_state, cmd, true, true);
+        } else {
+            send_uart_command_with_text(
+                input_state->uart_command, input_state->input_buffer, input_state);
+            uart_receive_data(
+                input_state->uart_context,
+                input_state->view_dispatcher,
+                input_state,
+                "",
+                "",
+                "");
+        }
     }
-    uart_receive_data(
-        input_state->uart_context, input_state->view_dispatcher, input_state, "", "", "");
     if(input_state->input_buffer) memset(input_state->input_buffer, 0, INPUT_BUFFER_SIZE);
 }
 
@@ -2134,6 +2148,9 @@ static void send_ir_file(AppState* state) {
     state->ir_file_buttons_mode = true;
 
     if(!ir_parse_buttons_from_ir_buffer(state, state->ir_file_buffer, state->ir_file_buffer_size)) {
+        free(state->ir_file_buffer);
+        state->ir_file_buffer = NULL;
+        state->ir_file_buffer_size = 0;
         state->ir_file_buttons_mode = false;
         ir_show_error(state, "No IR buttons found.");
         return;
@@ -2974,11 +2991,7 @@ bool back_event_callback(void* context) {
 
         // Cleanup text buffer
         if(state->textBoxBuffer) {
-            free(state->textBoxBuffer);
-            state->textBoxBuffer = malloc(1);
-            if(state->textBoxBuffer) {
-                state->textBoxBuffer[0] = '\0';
-            }
+            state->textBoxBuffer[0] = '\0';
             state->buffer_length = 0;
         }
 
@@ -3076,6 +3089,14 @@ bool back_event_callback(void* context) {
     }
     // Handle IR submenus (31-33)
     else if(current_view >= 31 && current_view <= 33) {
+        if(state->ir_file_buffer) {
+            free(state->ir_file_buffer);
+            state->ir_file_buffer = NULL;
+            state->ir_file_buffer_size = 0;
+        }
+        state->ir_file_buttons_mode = false;
+        state->ir_universal_buttons_mode = false;
+
         show_ir_menu(state);
         submenu_set_selected_item(state->ir_menu, state->last_ir_index);
         state->current_view = 30;

src/uart_utils.c

@@ -29,18 +29,19 @@ typedef enum {
     MARKER_STATE_CLOSE
 } MarkerState;
 
-static TextBufferManager* text_buffer_alloc(void) {
+static TextBufferManager* text_buffer_alloc(char* view_buffer) {
+    if(!view_buffer) return NULL;
+
     TextBufferManager* manager = malloc(sizeof(TextBufferManager));
     if(!manager) return NULL;
 
     manager->ring_buffer = malloc(RING_BUFFER_SIZE);
-    manager->view_buffer = malloc(VIEW_BUFFER_SIZE);
+    manager->view_buffer = view_buffer;
     manager->mutex = furi_mutex_alloc(FuriMutexTypeNormal);
 
-    if(!manager->ring_buffer || !manager->view_buffer || !manager->mutex) {
+    if(!manager->ring_buffer || !manager->mutex) {
         free(manager->ring_buffer);
-        free(manager->view_buffer);
-        free(manager->mutex);
+        if(manager->mutex) furi_mutex_free(manager->mutex);
         free(manager);
         return NULL;
     }
@@ -59,7 +60,6 @@ static void text_buffer_free(TextBufferManager* manager) {
     if(!manager) return;
     if(manager->mutex) furi_mutex_free(manager->mutex);
     free(manager->ring_buffer);
-    free(manager->view_buffer);
     free(manager);
 }
 
@@ -536,7 +536,7 @@ UartContext* uart_init(AppState* state) {
     }
 
     // Initialize text manager
-    uart->text_manager = text_buffer_alloc();
+    uart->text_manager = text_buffer_alloc(state->textBoxBuffer);
     if(!uart->text_manager) {
         FURI_LOG_E("UART", "Failed to allocate text manager");
         uart_free(uart);

src/uart_utils.h

@@ -23,7 +23,7 @@
 
 #define BAUDRATE (115200)
 
-#define TEXT_BOX_STORE_SIZE           (4096) // 4KB text box buffer size
+#define TEXT_BOX_STORE_SIZE           (8 * 1024) // 8KB text box buffer size
 #define RX_BUF_SIZE                   2048
 #define PCAP_BUF_SIZE                 4096
 #define STORAGE_BUF_SIZE              4096
@@ -33,8 +33,8 @@
 #define GHOST_ESP_APP_FOLDER_LOGS     "/ext/apps_data/ghost_esp/logs"
 #define GHOST_ESP_APP_SETTINGS_FILE   "/ext/apps_data/ghost_esp/settings.ini"
 #define ESP_CHECK_TIMEOUT_MS          100
-#define VIEW_BUFFER_SIZE              (16 * 1024) // 16KB for view
-#define RING_BUFFER_SIZE              (8 * 1024) // 8KB for incoming data
+#define VIEW_BUFFER_SIZE              TEXT_BOX_STORE_SIZE
+#define RING_BUFFER_SIZE              (4 * 1024) // 4KB for incoming data
 #define PCAP_GLOBAL_HEADER_SIZE       24
 #define PCAP_PACKET_HEADER_SIZE       16
 #define PCAP_TEMP_BUFFER_SIZE         4096